-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythia8 seeding improvements #13281
Pythia8 seeding improvements #13281
Conversation
This commit improves the seeding of Pythia8 in O2. The seeding... (a) ... is now done as part of the object's Init function automatically. Users are no longer required to provide own seeding logic, which can significantly simplify the setup. By default, Pythia8 will seed against ROOT TRandom::GetSeed, which is itself set to values of the command line option `--seed`, used in the o2-sim ... or o2-sim-dpl-eventgen execetuables (which are the 2 places undertaking event generation). This setup guarantees that ``` o2-sim-dpl-eventgen --generator pythiapp --seed x ``` will result in different event sequences when x changes. (b) Users can simply set the seed via a `setInitialSeed` function on the GeneratorPythia8 object. The function must be called before GeneratorPythia8::Init is executed. So calling it right after the constructor is fine. Example code (e.g., inside user Generator macro) is: ``` auto mygen = new o2::eventgen::GeneratorPythia8(); long seed = atol(getenv(ALIEN_PROC_ID)); if(!mygen->setInitialSeed(seed)) { std::cerr << "seeding failed"; } ``` In result, the commit leads to a simplification of the Pythia8 setup also in GeneratorFactory.
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Error while checking build/O2/fullCI for 75f9579 at 2024-07-08 17:48:
Full log here. |
This commit harmonizes the seeding procedure of generators based on o2::eventgen::GeneratorPythia8, following a development done in O2 (AliceO2Group/AliceO2#13281) In principle, o2::eventgen::GeneratorPythia8 now performs it's own seeding within the Init function. This seeding makes sure to integrate with the `--seed` command line option of our event generation executable. The commit: * Removes seeding code in O2DPG when it would override the default behaviour from O2. * Uses a new dedicated function `setInitialSeed` instead of manipulating Pythia8 with config strings (in situations in which the user targets seeding based on ALIEN_PROC_ID for instance). * Ensures that event generation becomes more repeatable in situations when the same `--seed` is given to the event generation executable. This may help to debug crashes on the GRID etc.
This commit harmonizes the seeding procedure of generators based on o2::eventgen::GeneratorPythia8, following a development done in O2 (AliceO2Group/AliceO2#13281) In principle, o2::eventgen::GeneratorPythia8 now performs it's own seeding within the Init function. This seeding makes sure to integrate with the `--seed` command line option of our event generation executable. The commit: * Removes seeding code in O2DPG when it would override the default behaviour from O2. * Uses a new dedicated function `setInitialSeed` instead of manipulating Pythia8 with config strings (in situations in which the user targets seeding based on ALIEN_PROC_ID for instance). * Ensures that event generation becomes more repeatable in situations when the same `--seed` is given to the event generation executable. This may help to debug crashes on the GRID etc.
This commit harmonizes the seeding procedure of generators based on o2::eventgen::GeneratorPythia8, following a development done in O2 (AliceO2Group/AliceO2#13281) In principle, o2::eventgen::GeneratorPythia8 now performs it's own seeding within the Init function. This seeding makes sure to integrate with the `--seed` command line option of our event generation executable. The commit: * Removes seeding code in O2DPG when it would override the default behaviour from O2. * Uses a new dedicated function `setInitialSeed` instead of manipulating Pythia8 with config strings (in situations in which the user targets seeding based on ALIEN_PROC_ID for instance). * Ensures that event generation becomes more repeatable in situations when the same `--seed` is given to the event generation executable. This may help to debug crashes on the GRID etc.
This commit harmonizes the seeding procedure of generators based on o2::eventgen::GeneratorPythia8, following a development done in O2 (AliceO2Group/AliceO2#13281) In principle, o2::eventgen::GeneratorPythia8 now performs it's own seeding within the Init function. This seeding makes sure to integrate with the `--seed` command line option of our event generation executable. The commit: * Removes seeding code in O2DPG when it would override the default behaviour from O2. * Uses a new dedicated function `setInitialSeed` instead of manipulating Pythia8 with config strings (in situations in which the user targets seeding based on ALIEN_PROC_ID for instance). * Ensures that event generation becomes more repeatable in situations when the same `--seed` is given to the event generation executable. This may help to debug crashes on the GRID etc.
This commit improves the seeding of Pythia8 in O2. The seeding...
(a) ... is now done as part of the object's Init function automatically.
Users are no longer required to provide own seeding logic,
which can significantly simplify the setup.
By default, Pythia8 will seed against ROOT TRandom::GetSeed,
which is itself set to values of the command line option
--seed
,used in the o2-sim ... or o2-sim-dpl-eventgen execetuables (which
are the 2 places undertaking event generation). This setup guarantees
that
(b) Users can simply set the seed via a
setInitialSeed
functionon the GeneratorPythia8 object. The function must be called before
GeneratorPythia8::Init is executed. So calling it right after the constructor
is fine.
In result, the commit leads to a simplification of the Pythia8 setup also in GeneratorFactory.