Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: Move DataInputDirector to arrow::Dataset API #13763

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ktf
Copy link
Member

@ktf ktf commented Dec 3, 2024

No description provided.

@ktf ktf requested a review from a team as a code owner December 3, 2024 15:02
Copy link
Contributor

github-actions bot commented Dec 3, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ktf
Copy link
Member Author

ktf commented Dec 3, 2024

First step towards being able to read and write RNTuple and TTree seamleassly.

@ktf
Copy link
Member Author

ktf commented Dec 4, 2024

Tested on hyperloop. Not OK. One leak fixed, one more to go.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 8c955dd at 2024-12-14 04:53:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13763-slc8_x86-64/0/Framework/AnalysisSupport/src/DataInputDirector.cxx:373:34: error: 'TTreeFileFormat' was not declared in this scope
/sw/SOURCES/O2/13763-slc8_x86-64/0/Framework/AnalysisSupport/src/DataInputDirector.cxx:373:50: error: no matching function for call to 'make_shared<<expression error> >(std::size_t&, std::size_t&)'
/sw/SOURCES/O2/13763-slc8_x86-64/0/Framework/AnalysisSupport/src/DataInputDirector.cxx:373:50: error: template argument 1 is invalid
/sw/SOURCES/O2/13763-slc8_x86-64/0/Framework/AnalysisSupport/src/DataInputDirector.cxx:373:50: error: template argument 1 is invalid
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(o2::framework::TFileFileSystem*&, TFile*, int)'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:96:17: error: no matching function for call to 'o2::framework::TFileFileSystem::TFileFileSystem(TFile*, int)'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:119:7: error: no matching function for call to 'o2::framework::TFileFileSystem::TFileFileSystem(TFile*, int)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 84ca389 at 2025-01-01 00:35:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[68498:calib-phos-l1phase]: [23:35:25][ERROR] Exception while running: Fatal error. Rethrowing.
[68498:calib-phos-l1phase]: [23:35:25][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch//PHS/Calib/BadMap/1735688125023/
[68498:calib-phos-l1phase]: [23:35:25][FATAL] Got nullptr from CCDB for path PHS/Calib/BadMap and timestamp 1735688125023
[68498:calib-phos-l1phase]: [23:35:25][ERROR] Exception while running: Fatal error. Rethrowing.
[68498:calib-phos-l1phase]: [23:35:25][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 68498 (calib-phos-l1phase) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/f1ba50d9bb49f31cbc9651bb9748dfe47cd167f6/slc8_x86-64/o2checkcode/1.0-local434/etc/modulefiles
++ cat
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for f88e524 at 2025-01-16 06:31:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile tpcreco.log
./sim-challenge.logtpcreco.log:[7939:internal-dpl-ccdb-backend]: [06:31:40][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logtpcreco.log-[7939:internal-dpl-ccdb-backend]: [06:31:40][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[7939:internal-dpl-ccdb-backend]: [06:31:40][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[7939:internal-dpl-ccdb-backend]: [06:31:40][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/TPC/Calib/CorrectionMapV2 for 1546300800000 (agent_id: alimetal01.cern.ch-1737005492-LT3fPb) with http code: 0
./sim-challenge.log[7939:internal-dpl-ccdb-backend]: [06:31:40][ERROR] File TPC/Calib/CorrectionMapV2 could not be retrieved. No more hosts to try.
./sim-challenge.log[7939:internal-dpl-ccdb-backend]: [06:31:40][FATAL] Unable to find object TPC/Calib/CorrectionMapV2/1546300800000
./sim-challenge.log[7939:internal-dpl-ccdb-backend]: [06:31:40][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[7939:internal-dpl-ccdb-backend]: [06:31:40][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 7939 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 7939 (exit 128)
./sim-challenge.log[INFO]    - First error: [06:31:40][FATAL] Unable to find object TPC/Calib/CorrectionMapV2/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (7939) had at least one message above severity 5: Unable to find object TPC/Calib/CorrectionMapV2/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[5478:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants