Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to thin only a percentage of the production #1837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chiarazampolli
Copy link
Collaborator

@chiarazampolli chiarazampolli commented Dec 6, 2024

@ddobrigk , @mfaggin , @catalinristea , @alcaliva
@ddobrigk , @mfaggin , please take a careful look. I will merge upon your confirmation.

If we want to add a metadata at the same time, for the case where we thin, let me know what I should use.

== Update ==
As discussed below, the use of metadata is not ok, there might be the need for deeper changes. So the second commit forbids that we can use it for now. The lines that forbid it should be removed when things are mature.

Copy link

github-actions bot commented Dec 6, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@mfaggin
Copy link
Contributor

mfaggin commented Dec 6, 2024

thanks @chiarazampolli , the logic looks ok to me. Regarding metadata I've no experience, last word to @ddobrigk for it

@chiarazampolli
Copy link
Collaborator Author

As discussed in the mail thread, we cannot use metadata in case AODs get merged (which is not the case at the moment in data reco, but one never knows). We'll need some further development.
This means that for now the percentage option should not be used. I will add a protection, leaving the code there for when things will be mature.

Chiara

@chiarazampolli
Copy link
Collaborator Author

The second commit avoids that we can use the option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants