[PWGJE] modification of hfj tagging def #9003
Conversation
hanseopark
requested review from
alibuild,
maoyx,
nzardosh,
fjonasALICE,
mfasDa and
mhemmer-cern
as code owners
github-actions
bot
changed the title
| switch (status) { | ||
| case 33: | ||
| return 1; // High priority | ||
| case 43: | ||
| return 2; | ||
| case 23: | ||
| return 3; | ||
| case 63: | ||
| return 4; | ||
| case 51: | ||
| return 5; | ||
| default: | ||
| return 6; |
There was a problem hiding this comment.
Don't use magic numbers. See the coding guidelines.
Define an enumerator with names for these values.
| if (origin == 2) { | ||
| return JetTaggingSpecies::beauty; | ||
| } | ||
| if (origin == 2) { |
There was a problem hiding this comment.
Don't use hard-coded values that are represented by enumerator names.
| adaptAnalysisTask<JetTaggerhfCharged>(cfgc, | ||
| SetDefaultProcesses{}, TaskName{"jet-taggerhf-charged"})); // o2-linter: disable=name/o2-task |
There was a problem hiding this comment.
Don't disable linter warnings without a valid reason. Address them.
There was a problem hiding this comment.
Thank you Vit, but I am sorry that I don't know to fix them. I have already reported for this issue like
Specified task name jet-taggerhf-qa-charged and the struct name JetTaggerhfQaCharged produce the same device name jet-taggerhf-qa-charged. TaskName is redundant. [name/o2-task]
Do you show the solution?
There was a problem hiding this comment.
"TaskName is redundant." means you should remove it.
|
Hi Hanseo can you add some description for booking keeping about what the new definition you have chosen is? Is this the definition that should be taken as default from here on @hahassan7 ? |
Core/JetTaggingUtilites.h
Modification of definition about HFJ tagging
-- The original function stopped immediately if a b or c quark was found, but the current function checks all jet constituents before deciding.
Tasks/JetTaggerHFQA.cxx
To fix weighted function
Add validation process function to compare