Make environment truncate correctly #8

rhaps0dy · 2024-04-15T23:28:17Z

I implemented and added tests for:

the environment returns truncate=True (rather than terminate=True) when the time limit is exceeded
when the environment gets solved at the very last step when it would be truncated, it's returned as terminated

I also fixed a previous bug:

Python tests failing would not make CI fail. pytest.main is not enough, one needs to explicitly check its return value and exit with it.

taufeeque9

LGTM. Left a comment regarding a test being skipped right now.

envpool/sokoban/sokoban_py_envpool_test.py

rhaps0dy added 5 commits April 15, 2024 11:39

Don't truncate episodes that finish at the last step.

58eae4e

The start of a test

f83f79b

Fix variable name

bc5ba8e

Test that environment terminates/truncates correctly

8ce206a

Make sure the tests pass in CI

42254d2

rhaps0dy requested a review from taufeeque9 April 15, 2024 23:28

rhaps0dy added 2 commits April 15, 2024 16:31

Prevent JVM from running out of memory

e4876f8

Load other levels first

1621daf

taufeeque9 approved these changes Apr 16, 2024

View reviewed changes

Fix review

1d6e81b

rhaps0dy enabled auto-merge April 25, 2024 05:33

rhaps0dy mentioned this pull request Apr 25, 2024

reduce action space to 4 #9

Merged

rhaps0dy added 2 commits April 24, 2024 22:57

Fix incorrect truncation

d467459

Explicitly skip astar_log test

534a086

rhaps0dy disabled auto-merge April 25, 2024 06:01

rhaps0dy merged commit 497309d into sokoban Apr 25, 2024
2 checks passed

rhaps0dy deleted the truncation branch April 25, 2024 06:02

Provide feedback