Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra newline bug #363

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix extra newline bug #363

merged 1 commit into from
Dec 22, 2023

Conversation

theSage21
Copy link
Collaborator

#163

  • The bug was being caused since self.start was retaining the False value
  • I've added tests to ensure this does not regress.

@theSage21 theSage21 self-assigned this Jun 23, 2021
@theSage21 theSage21 changed the title Squashed commit of the following: Fix extra newline bug Jun 23, 2021
@theSage21
Copy link
Collaborator Author

theSage21 commented Jun 23, 2021 •
edited
Loading

@Alir3z4 am I doing something wrong? The CI is not triggering for this pull request.

@Alir3z4
Copy link
Owner

Alir3z4 commented Sep 19, 2021

@Alir3z4 am I doing something wrong? The CI is not triggering for this pull request.

You're not doing anything wrong.
Travis CI doesn't love us anymore .

I'm trying to replicate what Travis-CI made using Github actions, but cannot do it properly (see #358)

@theSage21 @Alir3z4
Squashed commit of the following:
1059fef 
commit 88e0b49
Author: arjoonn sharma <arjoonn.94@gmail.com>
Date:   Tue Jun 22 22:14:44 2021 +0530

    fix newline bug

commit 820b779
Author: arjoonn sharma <arjoonn.94@gmail.com>
Date:   Tue Jun 22 21:32:44 2021 +0530

    add failing test
@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c4f446) 97.21% compared to head (1059fef) 97.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   97.21%   97.23%   +0.02%     
==========================================
  Files          10       11       +1     
  Lines        1113     1122       +9     
==========================================
+ Hits         1082     1091       +9     
  Misses         31       31
Flag Coverage Δ
unittests-3.10 97.23% <100.00%> (+0.02%) ⬆️
unittests-3.11 97.23% <100.00%> (+0.02%) ⬆️
unittests-3.12 97.23% <100.00%> (+0.02%) ⬆️
unittests-3.8 97.23% <100.00%> (+0.02%) ⬆️
unittests-3.9 97.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alir3z4 Alir3z4 self-requested a review December 22, 2023 22:13
@Alir3z4 Alir3z4 merged commit 099c4b8 into Alir3z4:master Dec 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richie0127 Richie0127 Richie0127 approved these changes

@Alir3z4 Alir3z4 Alir3z4 approved these changes

Assignees

@theSage21 theSage21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theSage21 @Alir3z4 @Richie0127