Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new line inside emphasis #368

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

aliana17
Copy link
Contributor

@aliana17 aliana17 commented Jul 5, 2021

Fixed ## # 151

  • Added a code that will move trailing line breaks outside of the asterisks and underscores.
  • Also changed a variable name list used inside a for loop to item as list is a python data type and it cannot be used as a variable name.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (099c4b8) 97.23% compared to head (b48cf24) 96.86%.

Files Patch % Lines
html2text/__init__.py 79.16% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   97.23%   96.86%   -0.38%     
==========================================
  Files          11       12       +1     
  Lines        1122     1149      +27     
==========================================
+ Hits         1091     1113      +22     
- Misses         31       36       +5     
Flag Coverage Δ
unittests-3.10 96.86% <83.33%> (-0.38%) ⬇️
unittests-3.11 96.86% <83.33%> (-0.38%) ⬇️
unittests-3.12 96.86% <83.33%> (-0.38%) ⬇️
unittests-3.8 96.86% <83.33%> (-0.38%) ⬇️
unittests-3.9 96.86% <83.33%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alir3z4
Copy link
Owner

Alir3z4 commented Dec 22, 2023

Could you please fix the failing CI and increase the coverage with tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants