Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI for button display #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anjali-vaish
Copy link

Pull Request: Improved Button Layout and Spacing for Binary Calculator

Fixes [#73 ]

Summary

This pull request introduces a refined styling update to the Binary Calculator's user interface, specifically focusing on button spacing and alignment. The changes ensure a cleaner and more user-friendly layout by adjusting the button sizes to be uniform and implementing consistent spacing between them.

Changes

  • Modified button width calculations to fit six buttons per row, accommodating margins.
  • Set a fixed height for all buttons to maintain uniformity.
  • Adjusted margins to ensure there is clear space between buttons, preventing overlap and sticking.
  • Used calc() in CSS to dynamically adjust button widths considering the margins.

Rationale

The previous button layout had issues with inconsistent button sizes and buttons sticking together without adequate spacing. These adjustments make the interface more visually appealing and easier to interact with, enhancing the overall user experience.

Screenshots

before
image

after
image

Request for Review

@Alitindrawan24 I kindly request a review from the team to ensure these changes meet our project's standards for design and functionality. Feedback or further suggestions for improvement are highly appreciated.

@Alitindrawan24
Copy link
Owner

@anjali-vaish I think current layout is still better and this PR contains conflict after I merged other PR

@anjali-vaish
Copy link
Author

@Alitindrawan24 I'll try and resolve this

@Alitindrawan24
Copy link
Owner

Your PR contain conflict after I'm merged other PR, plz solve the conflict first @anjali-vaish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants