Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 try to fix goroutines exportEventsTimeout #108

Merged

Conversation

wind2008hxy
Copy link
Contributor

What type of PR is this?
PR类型是什么?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

bug

What this PR does / why we need it:
这个PR解决了什么问题:
try to fix goroutines exportEventsTimeout
尝试修复travis ci 测试过程报错

image

Which issue(s) this PR fixes:
PR相关联issue:

Fixes #

Does this PR introduce a breaking change?:
PR带来的破坏性变更:

None


Test/Final result:
测试/最终运行结果:

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #108 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   50.97%   50.88%   -0.10%     
==========================================
  Files          27       27              
  Lines        1634     1637       +3     
==========================================
  Hits          833      833              
- Misses        729      732       +3     
  Partials       72       72              
Impacted Files Coverage Δ
sinks/webhook/webhook.go 26.80% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548ea0a...6091073. Read the comment docs.

@wind2008hxy
Copy link
Contributor Author

image

@wind2008hxy wind2008hxy reopened this May 20, 2020
@wind2008hxy
Copy link
Contributor Author

manager.ExportEvents(&batch)

&batch实际是同一个内存地址,多个goroutines尝试读取的时候,实际会是多个goroutines顺序读取,猜测是这里导致超时。

Copy link
Member

@ringtail ringtail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase

@wind2008hxy
Copy link
Contributor Author

rebase to one commit?

@ringtail
Copy link
Member

rebase to one commit?

Yes

@wind2008hxy
Copy link
Contributor Author

need rebase

rebase

@ringtail ringtail merged commit 9ec5456 into AliyunContainerService:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants