Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependencies to allow react v17 #84

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Update peer dependencies to allow react v17 #84

merged 1 commit into from
Nov 29, 2020

Conversation

ebual
Copy link
Contributor

@ebual ebual commented Nov 27, 2020

Installing react-lazy-load-image-component in a React v17 based project produces the following warnings:

warning " > react-lazy-load-image-component@1.5.0" has incorrect peer dependency "react@^15.x.x || ^16.x.x".
warning " > react-lazy-load-image-component@1.5.0" has incorrect peer dependency "react-dom@^15.x.x || ^16.x.x".

Since the react dev team postponed breaking changes to React v18 it is safe to update the peer dependencies.

@Aljullu
Copy link
Owner

Aljullu commented Nov 29, 2020

Thanks for the contribution @ebual, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants