Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master #4

Merged
merged 51 commits into from
May 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
26621fd
Add PGAM client side (#8418)
GeneGenie May 17, 2022
3ef3cf4
IX Bid Adapter: Outstream Support Update (#8412)
lksharma May 17, 2022
7f6914c
Alkimi Bid Adapter: Markdown file example update (#8422)
kalidas-alkimi May 17, 2022
49ea721
BeOp Bid Adapter: prefer canonical URL when present & prepend protoco…
cyppan May 17, 2022
4afcada
feat: add detected page url to ixdiag [PB-978] (#8425)
shahinrahbariasl May 17, 2022
8edfbc7
LiveIntent Id Submodule: Update live-connect to 2.3.3; better consent…
3link May 17, 2022
34622e3
support cta and privacyLink (#8403)
HashimotoLogly May 17, 2022
621a88d
Kargo Bid Adapter: adding media type to bid response, supporting vast…
andyrusiecki May 18, 2022
9d43d81
Improve Digital adapter: adding Extend mode (#8399)
jbartek25 May 18, 2022
979663e
Update sync URLs (#8431)
federicoizuel May 18, 2022
058a1e3
AdagioBidAdapter: remove useless data in bid request. (#8434)
osazos May 19, 2022
361730f
Prebid 6.25.0 release
prebidjs-release May 19, 2022
b2c496c
Increment version to 6.26.0-pre
prebidjs-release May 19, 2022
e23dba3
Ogury Bid Adapter: Add device infos with size in bidrequest (#8416)
jogury May 19, 2022
4ec44d2
Video Heroes Bid Adapter: add new bid adapter (#8310)
thebraveio May 20, 2022
a759c89
cpex Id module: Remove window reference (#8440)
EskelCz May 20, 2022
128d925
Jixie Bid Adapter: add schain (#8439)
jxdeveloper1 May 20, 2022
e700568
Gravito User Id submodule: initial release (#8414)
rahulgravito May 23, 2022
06ecc38
Rename id to aoneId from dacId (#8453)
haruka-yamashita2 May 24, 2022
c434889
Akamai RTD: fixed bugs on rtd module and added the entropy values (#8…
visrivastava May 24, 2022
f11bcda
Zeta global ssp bid adapter: add shortname param (#8454)
asurovenko-zeta May 24, 2022
a6e3c44
Remove medianetRtdProvider tests (#8463)
dgirardi May 24, 2022
170f6fd
Revert "Akamai RTD: fixed bugs on rtd module and added the entropy va…
patmmccann May 24, 2022
e728f54
Prebid 6.26.0 release
prebidjs-release May 24, 2022
b01ec40
Increment version to 6.27.0-pre
prebidjs-release May 24, 2022
14ae8d5
Update fintezaAnalyticsAdapter_spec.js (#8467)
patmmccann May 24, 2022
b97a0ea
Hadron analytics adapter: fix cross-origin exception on init (#8472)
dgirardi May 25, 2022
ce82891
Pulling the URL check out from the logic. Whatever the user passes wi…
ftxmoJason May 25, 2022
e106682
Update conversant adapter to accept position from the AdUnit (#8477)
johnwier May 25, 2022
80430aa
NovatiqId User Module - Include IAB Vendor ID (#8479)
rajsidhunovatiq May 25, 2022
8aaf01b
Multiple modules: attempt to reduce test flakiness, improved logging …
dgirardi May 25, 2022
5882444
Update to move floors logic after placement.sizes are defined (#8476)
mmoschovas May 26, 2022
0ab7e82
Adloox Analytics/RTD: prefer gpid over pbadslot (#8455)
jimdigriz May 26, 2022
2f33e7d
Akamai RTD: fixed bugs on rtd module and added the entropy values (#8…
visrivastava May 26, 2022
f39d849
SOVRN Bid Adapter: refactor old test code (#8430)
cpabst May 26, 2022
7576a67
Tests: remove console.log (#8481)
asurovenko-zeta May 26, 2022
a7891db
Kobler adapter: remove outdated parameters, simplify testing (#8445)
acsbendi May 26, 2022
b898bba
NaveggId module: fixed regex used to get naveggId from LocalStorage (…
jvnnc May 26, 2022
7116c9c
Taboola bid adapter: initial release (#8483)
mikizi May 26, 2022
d3ee8c7
Prebid 6.27.0 release
prebidjs-release May 26, 2022
90af31d
Increment version to 6.28.0-pre
prebidjs-release May 26, 2022
ac47d81
Ftrack Id Module: replace native appendChild with Prebid's loadExtern…
ftxmoJason May 26, 2022
0af8aa3
IncrementX Bid Adapter: Initial Release (#8316)
Prebid-Vertoz May 26, 2022
1463225
added tests for medianet rtd without loading js (#8485)
monis0395 May 27, 2022
8702ee5
Adyoulike Bidder Adapter - schain support (#8486)
guiann May 27, 2022
8976ebc
ZetaGlobalSsp BidAdapter: shortname to url (#8471)
asurovenko-zeta May 27, 2022
78bba8e
Akamai RTD Module: Fixed randomly failing test cases and updated the …
visrivastava May 27, 2022
783ec07
Adriver ID system: fix spurious test failure (#8489)
dgirardi May 27, 2022
5f2ed0f
Inskin bid adapter: use loadExternalScript utility instead of appendC…
cciocov May 30, 2022
5e44a1b
TheMediaGrid: support bid.ortb2.site.content.id (#8492)
TheMediaGrid May 31, 2022
e5b3877
Fix for #8421 (#8493)
parisholley May 31, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions integrationExamples/gpt/akamaidap_segments_example.html
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
}
},
realTimeData: {
auctionDelay: 2000,
dataProviders: [
{
name: "dap",
Expand All @@ -76,9 +77,10 @@
apiHostname: "prebid.dap.akadns.net",
apiVersion: "x1",
domain: "prebid.org",
identityType: "dap-signature:1.0.0",
segtax: 503,
tokenTtl: 5,
identityType: "dap-signature:1.3.0",
segtax: 504,
dapEntropyUrl: 'https://dap-dist.akamaized.net/dapentropy.js',
dapEntropyTimeout: 1500
}
}
]
Expand Down
3 changes: 3 additions & 0 deletions integrationExamples/gpt/userId_example.html
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,9 @@
},
{
"name": "dacId"
},
{
"name": "gravitompId"
}
],
"syncDelay": 5000,
Expand Down
4 changes: 3 additions & 1 deletion modules/.submodules.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,16 @@
"unifiedIdSystem",
"verizonMediaIdSystem",
"zeotapIdPlusIdSystem",
"adqueryIdSystem"
"adqueryIdSystem",
"gravitoIdSystem"
],
"adpod": [
"freeWheelAdserverVideo",
"dfpAdServerVideo"
],
"rtdModule": [
"airgridRtdProvider",
"akamaiDapRtdProvider",
"browsiRtdProvider",
"dgkeywordRtdProvider",
"geoedgeRtdProvider",
Expand Down
2 changes: 2 additions & 0 deletions modules/adagioBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,8 @@ export const spec = {
// remove useless props
delete adUnitCopy.floorData;
delete adUnitCopy.params.siteId;
delete adUnitCopy.userId
delete adUnitCopy.userIdAsEids

groupedAdUnits[adUnitCopy.params.organizationId] = groupedAdUnits[adUnitCopy.params.organizationId] || [];
groupedAdUnits[adUnitCopy.params.organizationId].push(adUnitCopy);
Expand Down
14 changes: 9 additions & 5 deletions modules/adlooxAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ MACRO['pageurl'] = function(b, c) {
const refererInfo = getRefererInfo();
return (refererInfo.canonicalUrl || refererInfo.referer || '').substr(0, 300).split(/[?#]/)[0];
};
MACRO['pbadslot'] = function(b, c) {
MACRO['gpid'] = function(b, c) {
const adUnit = find(auctionManager.getAdUnits(), a => b.adUnitCode === a.code);
return deepAccess(adUnit, 'ortb2Imp.ext.data.pbadslot') || getGptSlotInfoForAdUnitCode(b.adUnitCode).gptSlot || b.adUnitCode;
return deepAccess(adUnit, 'ortb2Imp.ext.gpid') || deepAccess(adUnit, 'ortb2Imp.ext.data.pbadslot') || getGptSlotInfoForAdUnitCode(b.adUnitCode).gptSlot || b.adUnitCode;
};
MACRO['pbAdSlot'] = MACRO['pbadslot']; // legacy
MACRO['pbAdSlot'] = MACRO['pbadslot'] = MACRO['gpid']; // legacy

const PARAMS_DEFAULT = {
'id1': function(b) { return b.adUnitCode },
'id2': '%%pbadslot%%',
'id2': '%%gpid%%',
'id3': function(b) { return b.bidder },
'id4': function(b) { return b.adId },
'id5': function(b) { return b.dealId },
Expand Down Expand Up @@ -138,7 +138,11 @@ analyticsAdapter.enableAnalytics = function(config) {
toselector: config.options.toselector || function(bid) {
let code = getGptSlotInfoForAdUnitCode(bid.adUnitCode).divId || bid.adUnitCode;
// https://mathiasbynens.be/notes/css-escapes
code = code.replace(/^\d/, '\\3$& ');
try {
code = CSS.escape(code);
} catch (_) {
code = code.replace(/^\d/, '\\3$& ');
}
return `#${code}`
},
client: config.options.client,
Expand Down
6 changes: 3 additions & 3 deletions modules/adlooxAnalyticsAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ For example, you have a number of reporting breakdown slots available in the for
tagid: 0,
params: {
id1: function(b) { return b.adUnitCode }, // do not change when using the Adloox RTD Provider
id2: '%%pbadslot%%', // do not change when using the Adloox RTD Provider
id2: '%%gpid%%', // do not change when using the Adloox RTD Provider
id3: function(b) { return b.bidder },
id4: function(b) { return b.adId },
id5: function(b) { return b.dealId },
Expand All @@ -125,9 +125,9 @@ For example, you have a number of reporting breakdown slots available in the for

The following macros are available

* `%%pbadslot%%`: [Prebid Ad Slot](https://docs.prebid.org/features/pbAdSlot.html) returns [`AdUnit.code`](https://docs.prebid.org/features/pbAdSlot.html) if set otherwise returns [`AdUnit.code`](https://docs.prebid.org/dev-docs/adunit-reference.html#adunit)
* **`%%gpid%%` (alias `%%pbadslot%%`**): [Prebid Ad Slot](https://docs.prebid.org/features/pbAdSlot.html) returns [`AdUnit.code`](https://docs.prebid.org/features/pbAdSlot.html) if set otherwise returns [`AdUnit.code`](https://docs.prebid.org/dev-docs/adunit-reference.html#adunit)
* it is recommended you read the [Prebid Ad Slot section in the Adloox RTD Provider documentation](./adlooxRtdProvider.md#prebid-ad-slot)
* `%%pageurl%%`: [`canonicalUrl`](https://docs.prebid.org/dev-docs/publisher-api-reference/setConfig.html#setConfig-Page-URL) from the [`refererInfo` object](https://docs.prebid.org/dev-docs/bidder-adaptor.html#referrers) otherwise uses `referer`
* **`%%pageurl%%`**: [`canonicalUrl`](https://docs.prebid.org/dev-docs/publisher-api-reference/setConfig.html#setConfig-Page-URL) from the [`refererInfo` object](https://docs.prebid.org/dev-docs/bidder-adaptor.html#referrers) otherwise uses `referer`

### Functions

Expand Down
8 changes: 3 additions & 5 deletions modules/adlooxRtdProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,11 @@ function init(config, userConsent) {
function getBidRequestData(reqBidsConfigObj, callback, config, userConsent) {
// gptPreAuction runs *after* RTD so pbadslot may not be populated... (╯°□°)╯ ┻━┻
const adUnits = (reqBidsConfigObj.adUnits || getGlobal().adUnits).map(adUnit => {
let path = deepAccess(adUnit, 'ortb2Imp.ext.data.pbadslot');
if (!path) path = getGptSlotInfoForAdUnitCode(adUnit.code).gptSlot;
return {
path: path,
gpid: deepAccess(adUnit, 'ortb2Imp.ext.gpid') || deepAccess(adUnit, 'ortb2Imp.ext.data.pbadslot') || getGptSlotInfoForAdUnitCode(adUnit.code).gptSlot || adUnit.code,
unit: adUnit
};
}).filter(adUnit => !!adUnit.path);
}).filter(adUnit => !!adUnit.gpid);

let response = {};
function setSegments() {
Expand Down Expand Up @@ -315,7 +313,7 @@ function getBidRequestData(reqBidsConfigObj, callback, config, userConsent) {
}
const atfQueue = [];
adUnits.map((adUnit, i) => {
const ref = [ adUnit.path ];
const ref = [ adUnit.gpid ];
if (!config.params.slotinpath) ref.push(adUnit.unit.code);
args.push(['s', ref.join('\t')]);

Expand Down
4 changes: 2 additions & 2 deletions modules/adlooxRtdProvider.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ To use this, you *must* also integrate the [Adloox Analytics Adapter](./adlooxAn

You may optionally pass a subsection `params` in the `params` block to the Adloox RTD Provider, these will be passed through to the segment handler as is and as described by the integration guidelines.

**N.B.** If you pass `params` to the Adloox Analytics Adapter, `id1` (`AdUnit.code`) and `id2` (`%%pbadslot%%`) *must* describe a stable identifier otherwise no usable segments will be served and so they *must not* be changed; if `id1` for your inventory could contain a non-stable random number please consult with us before continuing
**N.B.** If you pass `params` to the Adloox Analytics Adapter, `id1` (`AdUnit.code`) and `id2` (`%%gpid%%`) *must* describe a stable identifier otherwise no usable segments will be served and so they *must not* be changed; if `id1` for your inventory could contain a non-stable random number please consult with us before continuing

Though our segment technology is fast (less than 10ms) the time it takes for the users device to connect to our service and fetch the segments may not be. For this reason we recommend setting `auctionDelay` no lower than 100ms and if possible you should explore using user-agent sourced information such as [NetworkInformation.{rtt,downlink,...}](https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation) to dynamically tune this for each user.

Expand All @@ -94,7 +94,7 @@ You may use one of two ways to do achieve this:
* for display inventory [using GPT](https://developers.google.com/publisher-tag/guides/get-started) you may configure Prebid.js to automatically use the [full ad unit path](https://developers.google.com/publisher-tag/reference#googletag.Slot_getAdUnitPath)
1. include the [`gptPreAuction` module](https://docs.prebid.org/dev-docs/modules/gpt-pre-auction.html)
1. wrap both `pbjs.setConfig({...})` and `pbjs.enableAnalytics({...})` with `googletag.cmd.push(function() { ... })`
* set `pbadslot` in the [first party data](https://docs.prebid.org/dev-docs/adunit-reference.html#first-party-data) variable `AdUnit.ortb2Imp.ext.data.pbadslot` for all your ad units
* set `gpid` (or `pbadslot`) in the [first party data](https://docs.prebid.org/dev-docs/adunit-reference.html#first-party-data) variable `AdUnit.ortb2Imp.ext.gpid` (or `AdUnit.ortb2Imp.ext.data.pbadslot`) for all your ad units

## Timeouts

Expand Down
4 changes: 3 additions & 1 deletion modules/adtelligentBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const HOST_GETTERS = {
bidsxchange: () => 'ghb.hbd.bidsxchange.com',
streamkey: () => 'ghb.hb.streamkey.net',
janet: () => 'ghb.bidder.jmgads.com',
pgam: () => 'ghb.pgamssp.com',
}
const getUri = function (bidderCode) {
let bidderWithoutSuffix = bidderCode.split('_')[0];
Expand All @@ -37,7 +38,8 @@ export const spec = {
code: BIDDER_CODE,
gvlid: 410,
aliases: ['onefiftytwomedia', 'selectmedia', 'appaloosa', 'bidsxchange', 'streamkey', 'janet',
{ code: 'navelix', gvlid: 380 }
{ code: 'navelix', gvlid: 380 },
'pgam'
],
supportedMediaTypes: [VIDEO, BANNER],
isBidRequestValid: function (bid) {
Expand Down
3 changes: 3 additions & 0 deletions modules/adyoulikeBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ export const spec = {
if (typeof bidReq.getFloor === 'function') {
accumulator[bidReq.bidId].Pricing = getFloor(bidReq, size, mediatype);
}
if (bidReq.schain) {
accumulator[bidReq.bidId].SChain = bidReq.schain;
}
if (mediatype === NATIVE) {
let nativeReq = bidReq.mediaTypes.native;
if (nativeReq.type === 'image') {
Expand Down
Loading