Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve evaluation README with proper links and formatting #5221

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

young010101
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @young010101 , really sorry that I didn't see your PR before doing this, but I actually just queued up a big refactor of the eval directory here #5223 . I'll block this PR for now, but we can revisit it when #5223 is merged.

@young010101
Copy link
Contributor Author

Hey @young010101 , really sorry that I didn't see your PR before doing this, but I actually just queued up a big refactor of the eval directory here #5223 . I'll block this PR for now, but we can revisit it when #5223 is merged.

Thanks for your feedback! I'll wait for #5223 to be merged and then update my PR accordingly.

@mamoodi
Copy link
Collaborator

mamoodi commented Nov 25, 2024

The refactor is finished in case you want to continue with this @young010101

@young010101
Copy link
Contributor Author

The refactor is finished in case you want to continue with this @young010101

Clear refactor, @mamoodi. I've picked it up already. Could you please review it again?

@mamoodi
Copy link
Collaborator

mamoodi commented Nov 26, 2024

Looks good! Thanks!

@mamoodi mamoodi requested a review from neubig November 26, 2024 01:09
@neubig neubig merged commit b808a63 into All-Hands-AI:main Nov 27, 2024
14 checks passed
@young010101 young010101 deleted the fix/evaluation-readme-links branch December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants