Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended course info #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hanleybrand
Copy link

GET /courses/{courseId}/extended

Extends com.alltheducks.bbws.model.CourseDto, adds supporting methods - returns additional info
(rowStatus: 0-4 | U, isAvailable: true/false)

*important note: * currently courses with RowStatus=2 generate a 404 response: { "code": 404, "message": "Not Found"} - this will hopefully be addressed in the next week

We’ve been using your b2 at Temple for some faculty-centric SIS tools (thanks for releasing it!), but faculty were requesting being able to see if their courses were available or not.

Future plans:

  • refactor CourseExtendedDto to also return unavailable(row_status = '2') courses
  • add enrollment list (
    GET /courses/{courseId}/users_student
    and
    GET /courses/{courseId}/users_all
    )
  • investigate porting atd-enabler to a web service (so faculty can turn courses on and off in a similar manner to how qwickly implements their availability toggle)

If you think it's not worth having the extra extended (i.e. that it makes more sense to just have the already implemented /courses/{courseId}/ service include the availability info), reject the PR and I can refactor & re-submit.

Peter Hanley and others added 3 commits August 19, 2016 16:14
**GET** `/courses/{courseId}/extended`

Extends CourseDto, adds supporting methods - returns additional info
(rowStatus: 0-4 | U, isAvailable: true/false)

We’ve been using this b2 at Temple for some faculty-centric SIS tools,
but faculty were requesting being able to see if their courses were
available or not.

Future plans:

add enrollment list (**GET** `/courses/{courseId}/users_student` and
**GET** `/courses/{courseId}/users_all`

investigate porting atd-enabler to a web service (so faculty can turn
courses on and off similar to how qwickly does it)
stupid quote escaping
forgot the id >_<
@wileyfuller
Copy link
Member

thanks for the pull request. We've had a chat about your changes, and would like to go with your second suggestion. i.e. modifying the existing service to include availability info.

I can either leave this pull request open, and you can modify the code, or I can reject if you'd prefer to do it in a new PR.

@hanleybrand
Copy link
Author

This sounds great - I'll get this done asap (sorry for the delay). I guess I can just re-commit and this PR will stay open, so that's fine to do it that way.

@espeecat
Copy link

espeecat commented Aug 24, 2016

Hi
Just wanted to say that I've been testing this B2 out. Really useful -thank you. I've supplemented some of the methods with stuff we're intending to use i.e. to get attempt date for submissions. I also wanted info on assignment types (e.g. Turnitin, manual etc) so querying via the gradecenter seems the way to go. What this did show, for example, is that Turnitin aren't populating the gradecentre with due dates which would be useful.

I tried to mavenise it but had issues -not sure. It works fine with Gradle. I suspect this block won't work with the latest version of Blackboard but would be interested to know if anyone has tried. I'll download the latest VM when I get a chance.

Great stuff and glad to see it's being maintained.

p.s. we're on managed hosting to don't have access to the full database so using this to get data out is proving useful.

@hanleybrand
Copy link
Author

Out of curiosity - why do you think it won't work on the latest version? Do you mean Saas? Or Q2 2016?

We have a test instance of Q216 - I can throw the b2 up there and test it

(and also: yeah, we (Temple University) just moved to managed hosting too, and this b2 is looking helpful for getting the live data we used to get with direct sql queries)

@espeecat
Copy link

Hi
Blackboard mentioned that we have a lot of plugins/B2s on our instance of blackboard. We have lots of similar B2s that, for example, list modules (e.g. chemistry 101) by year/semester. We also have a news and announcement widget/B2.

Blackboard thought some of these might break in Q2 2016 (java 8). What we then found out was that anything written with the older Spring Framework would probably break and need updating. I'm assuming that as this project was started a while back then it's probably using an older version of Spring. I don't know which version of Spring is supported in Q2 2016 but I'm assuming it's related to being Java 8 so probably anything before Spring 4.x might not work in Q2 2016. It's all assumption, I'm afraid, as I've not had chance to test.

If you get chance to try it out then I'd love to know. I've just bought the Spring 4.3 book to work out the differences: https://www.amazon.co.uk/Getting-started-Spring-Framework-Third-ebook/dp/B01HZXQFUS/ref=dp_kinw_strp_1

Jas

@shaneargo
Copy link
Member

Spring must be updated to v4.25 to work on Java 8.

On 25 August 2016 at 20:27:22, Jason Bailey (notifications@github.com)
wrote:

Hi
Blackboard mentioned that we have a lot of plugins/B2s on our instance of
blackboard. We have lots of similar B2s that, for example, list modules
(e.g. chemistry 101) by year/semester. We also have a news and announcement
widget/B2.

Blackboard thought some of these might break in Q2 2016 (java 8). What we
then found out was that anything written with the older Spring Framework
would probably break and need updating. I'm assuming that as this project
was started a while back then it's probably using an older version of
Spring. I don't know which version of Spring is supported in Q2 2016 but
I'm assuming it's related to being Java 8 so probably anything before
Spring 4.x might not work in Q2 2016. It's all assumption, I'm afraid, as
I've not had chance to test.

If you get chance to try it out then I'd love to know. I've just bought the
Spring 4.3 book to work out the differences:
https://www.amazon.co.uk/Getting-started-Spring-Framework-Third-ebook/dp/B01HZXQFUS/ref=dp_kinw_strp_1

Jas


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2 (comment),
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AETghuar02DRSJWOOnUO5e5BdDk0-XVVks5qjW4KgaJpZM4Jo1cS
.

@hanleybrand
Copy link
Author

hanleybrand commented Jan 24, 2017

I haven't gotten around to updating my original b2 but a first pass at updating the b2 to work with q2 2016/SaaS is here: https://github.com/hanleybrand/atd-bbws/tree/q216_and_SASS

It needs to be its own pull request (I've tested it with q2 2016 (works) but not earlier versions so I don't know... actually I do know, it won't work with earlier versions because there were some API changes for gradebook stuff which would need to be handled.

btw only 2 lines of code plus the spring libraries were necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants