Skip to content

Commit

Permalink
fix: #678 refresh the engine configuration if settings change (#700)
Browse files Browse the repository at this point in the history
* fix: #678 refresh the engine configuration if settings change

* chore: rename engine settings refresh method
  • Loading branch information
mathPi authored Aug 27, 2024
1 parent a03774e commit 1968c03
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/main/python/main/ayab/ayab.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def __activate_menu(self) -> None:
def __set_prefs(self) -> None:
self.prefs.open_dialog()
self.scene.refresh()
self.engine.reload_settings()

def __quit(self) -> None:
logging.debug("Quitting")
Expand Down
7 changes: 5 additions & 2 deletions src/main/python/main/ayab/engine/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def __init__(self, parent: GuiMain):
self.ui.setupUi(self)
self.config: OptionsTab = OptionsTab(parent)
self.config.portname = self.__read_portname()
self.config.refresh()
self.reload_settings()
self.status = StatusTab()
self.setup_ui()
parent.ui.dock_container_layout.addWidget(self)
Expand All @@ -70,7 +70,6 @@ def __init__(self, parent: GuiMain):
self.control = Control(parent, self)
self.__feedback = FeedbackHandler(parent)
self.__logger = logging.getLogger(type(self).__name__)
self.setWindowTitle("Machine: " + Machine(self.config.machine).name)

def __del__(self) -> None:
self.control.stop()
Expand All @@ -90,6 +89,10 @@ def setup_ui(self) -> None:
# activate UI elements
self.__activate_ui()

def reload_settings(self) -> None:
self.config.refresh()
self.setWindowTitle("Machine: " + Machine(self.config.machine).name)

def __disable_status_tab(self) -> None:
self.ui.tab_widget.setTabEnabled(1, False)
self.status.ui.label_progress.setText("")
Expand Down

0 comments on commit 1968c03

Please sign in to comment.