Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make glfw backend optional #5

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

ptxmac
Copy link
Contributor

@ptxmac ptxmac commented Sep 3, 2022

This allows cimgui-go to "almost" be a drop-in replacement for imgui-go

I choose to make the GLFW backend opt-in since that's what makes the most sense for my use-case, but depending on other uses it might be better to have it opt-out instead

@AllenDang AllenDang merged commit ed7c135 into AllenDang:main Sep 5, 2022
@AllenDang
Copy link
Owner

I think we should add exclude tag rather then a include tag. Because by default, cimgui should be a runnable project with default backend, unless user wants to explicitly exclude the backend.

Otherwise all down-stream package like giu should add a build tag.

@ptxmac
Copy link
Contributor Author

ptxmac commented Sep 5, 2022

I think we should add exclude tag rather then a include tag. Because by default, cimgui should be a runnable project with default backend, unless user wants to explicitly exclude the backend.

Otherwise all down-stream package like giu should add a build tag.

yeah, fine by me - I did expect you to change it before merging 😄

@AllenDang
Copy link
Owner

@ptxmac Ok, it is changed by recent commit.

gucio321 pushed a commit to gucio321/cimgui-go that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants