react-toastr 2.8.2 breaking build #838

aliabbas · 2016-11-16T18:51:23Z

when webpacking my application with react-bootstrap-table, the react-toastr@^2.8.0 dependecy pulls in 2.8.2 as it should but I'm getting the following error

./~~/react-bootstrap-table/~~/react-toastr/~/react/lib/ReactTransitionEvents.js
Module not found: Error: Cannot resolve module 'react-dom/lib/getVendorPrefixedEventName'

i'm using node 4.3.1, npm 2.15.1

sgentile · 2016-11-16T21:03:33Z

Not sure if related, but I got a reactDOM error with react-toastr using the very new 15.4.0

kellyi · 2016-11-16T21:18:38Z

I encountered this issue, too. I think removing the caret from this line in package.json would fix it by pinning it to always use react-toastr 2.8.0:

https://github.com/AllenFang/react-bootstrap-table/blob/master/package.json#L67

madeinfree · 2016-11-17T01:10:52Z

Hi, @aliabbas @sgentile @kellyi I see the related issue from tomchentw/react-toastr#86

kellyi · 2016-11-17T01:13:04Z

It seems like updating React and ReactDOM to 15.4.0 remedied this issue when using v2.5.8 of this library.

AllenFang · 2016-11-17T01:43:49Z

Just like @kellyi said, I think fix the verion of react-toastr is a workaround currently.

gravitycode · 2016-11-21T13:42:52Z

Oh no! the damn caret.

AllenFang · 2016-11-21T15:43:16Z

Fixed on v2.5.9, please upgrade, Solve it by fix react-toastr on v2.8.0

mangreen · 2016-11-22T07:40:31Z

After changed to install react-bootstrap-table@2.5.9, I still encountered this issue.
My react is 0.14.8 and react-dom is 0.14.7

module.js:338
throw err;
^
Error: Cannot find module 'react-dom/lib/getVendorPrefixedEventName'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/Users/XXXXX/Workspace/test/node_modules/react-bootstrap-table/node_modules/react-toastr/node_modules/react/lib/ReactTransitionEvents.js:15:34)
at Module._compile (module.js:460:26)
at Module._extensions..js (module.js:478:10)
at Object.require.extensions.(anonymous function) [as .js] (/Users/XXXXX/Workspace/test/node_modules/babel-core/lib/api/register/node.js:214:7)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)

vapon · 2016-11-22T08:08:02Z

Hi, that is true.
react-bootstrap-table@2.5.9 doesn't resolve the problem.
"Module not found: Error: Cannot resolve module 'react-dom/lib/getVendorPrefixedEventName'"

gravitycode · 2016-11-22T08:20:56Z

i finally updated to react 15.4.0. Although I think not in all scenarios this is a viable solution.
I also had to update react-hot-loader

madeinfree · 2016-11-22T08:33:56Z

I think this problem from React 15.4.0, I try to change react-toastr react-dom version into 15.3.0 and problem be resolved, react-toastr use below

"dependencies": {
  "react-dom": "^0.14.0 || ^15.0.0"
}

so it will install react-dom 15.4.0 by itself

-- version

react-bootstrap-table 2.5.9
react 0.14.8
react-dom 0.14.8
react-toastr 2.8.0
- react-dom 15.3.0

--- Edit ---

AllenFang · 2016-11-22T08:38:41Z

HI everyone, that's my fault, its a invalid fixed. Any solution?

vapon · 2016-11-22T08:43:05Z

That is the example how caret dependencies can ruin the build. My project become invalid after react 15.4.0 was released (https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html)
Which version of the react-bootstrap-table uses react-toastr 2.4.0 ? I might downgrade for now.

AllenFang · 2016-11-22T08:45:57Z

but maybe https://github.com/tomchentw/react-toastr/blob/v2.4.0/package.json#L78 will be a problem.

AllenFang · 2016-11-22T08:46:39Z

How about fork react-toastr to my repo and link it with git repo url in package.json

madeinfree · 2016-11-22T08:49:36Z

agree! maybe this is the temporary solution to fix this problem when react-toastr didn't fix this problem.

vapon · 2016-11-22T08:51:16Z

Thank you very much! Will check which solution fits better.

kellyi · 2016-11-22T13:29:35Z

Upgrading the top-level React & React-DOM dependencies to 15.4.0 fixed this issue for me.

I believe the problem's that React-Toastr's using an undocumented API which was done away with in 15.4.0. The dependency started breaking immediately after React 15.4 was released -- and this was published:

https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html

I think having the latest React installed at the top level will fix it temporarily, although I also think the React-Toastr dependency will fail again whenever the React version's incremented. A long-term fix probably has to involve React-Toastr adjusting how it addresses the React & React-DOM APIs.

kellyi · 2016-11-22T13:32:03Z

@AllenFang I think using a forked version of React-Toastr with the React/React-DOM-dependencies pinned at whatever version you want for this would work, too.

It looks as if this might be the/one of the culprits in React-Toastr:

https://github.com/tomchentw/react-toastr/blob/b0fadc4afd51d381b983ce499d6cdfb667d319d2/lib/ToastMessage/animationMixin.js#L7

AllenFang · 2016-11-22T13:57:03Z

I think using a forked version of React-Toastr with the React/React-DOM-dependencies pinned at whatever version you want for this would work, too.

yes, I'll fix it later :) Thanks all you guys give these feedback 👍

AllenFang · 2016-11-22T17:04:05Z

hi all, I've released v2.5.10, I think it could fix this issue, please let me know if anything goes wrong. Any feedback is welcome :) thanks.

yschoueri · 2016-11-22T20:51:22Z

It doesn't work for me with package.json dependency
"react-bootstrap-table": "2.5.10"

I get the following error/warning when running npm install

`-- react-bootstrap-table@2.5.10
  +-- UNMET PEER DEPENDENCY react@^0.14.0 || <15.4.0
  `-- react-toastr@2.8.2  (git+https://github.com/AllenFang/react-toastr.git#777bb9a700de183bd123e9f6e2845164cd77ed87)
    +-- react-addons-update@15.3.2
    `-- react-dom@15.3.2

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: fsevents@1.0.15
npm WARN react-toastr@2.8.2 requires a peer of react@^0.14.0 || <15.4.0 but none was installed.

and this one when starting my server in hot reload

ERROR in ./~/react-bootstrap-table/lib/toolbar/ToolBar.js
Module not found: Error: Cannot resolve module 'react-modal' in C:\Users\yschoueri.STW\Documents\Code\bidconf-ui\node_modules\react-bootstrap-table\lib\toolbar
 @ ./~/react-bootstrap-table/lib/toolbar/ToolBar.js 25:18-40

ERROR in ./~/react-toastr/~/react-dom/index.js
Module not found: Error: Cannot resolve module 'react/lib/ReactDOM' in C:\Users\yschoueri.STW\Documents\Code\bidconf-ui\node_modules\react-toastr\node_modules\react-dom
 @ ./~/react-toastr/~/react-dom/index.js 3:17-46

Shaywei · 2016-11-22T20:55:37Z

I am getting erros on npm install:

ERROR in ./~/react-bootstrap-table/lib/toolbar/ToolBar.js
Module not found: Error: Cannot resolve module 'react-modal' in /Users/shayweiss/git/.../frontend/node_modules/react-bootstrap-table/lib/toolbar
 @ ./~/react-bootstrap-table/lib/toolbar/ToolBar.js 25:18-40

ERROR in ./~/react-toastr/~/react-dom/index.js
Module not found: Error: Cannot resolve module 'react/lib/ReactDOM' in /Users/shayweiss/git/.../frontend/node_modules/react-toastr/node_modules/react-dom
 @ ./~/react-toastr/~/react-dom/index.js 3:17-46

Reverting to 2.5.8 solved the problem.

qiusli · 2016-11-22T22:28:59Z

Got the following error building my project, not sure why. Any suggestions?

npm ERR! git clone --template=h:\dash\npm\2\npm-cache_git-remotes_templates --mirror https://github.com/AllenFang/reac
t-toastr.git h:\dash\npm\2\npm-cache_git-remotes\git-https-github-com-AllenFang-react-toastr-git-72d29d72: Cloning into
bare repository 'h:\dash\npm\2\npm-cache_git-remotes\git-https-github-com-AllenFang-react-toastr-git-72d29d72'...
npm ERR! git clone --template=h:\dash\npm\2\npm-cache_git-remotes_templates --mirror https://github.com/AllenFang/reac
t-toastr.git h:\dash\npm\2\npm-cache_git-remotes\git-https-github-com-AllenFang-react-toastr-git-72d29d72:
npm ERR! git clone --template=h:\dash\npm\2\npm-cache_git-remotes_templates --mirror https://github.com/AllenFang/reac
t-toastr.git h:\dash\npm\2\npm-cache_git-remotes\git-https-github-com-AllenFang-react-toastr-git-72d29d72: fatal: Unabl
e to find remote helper for 'https'
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "c:\PROGRA~~1\nodejs\63847A~~1.1\node.exe" "c:\PROGRA~~1\nodejs\63847A~~1.1\node_modules\npm\bin\np
m-cli.js" "install"
npm ERR! node v6.3.1
npm ERR! npm v3.10.3
npm ERR! code 128

npm ERR! Command failed: git -c core.longpaths=true clone --template=h:\dash\npm\2\npm-cache_git-remotes_templates --m
irror https://github.com/AllenFang/react-toastr.git h:\dash\npm\2\npm-cache_git-remotes\git-https-github-com-AllenFang-
react-toastr-git-72d29d72
npm ERR! fatal: Unable to find remote helper for 'https'
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR! https://github.com/npm/npm/issues

npm ERR! Please include the following file with any support request:

sgentile · 2016-11-22T22:29:53Z

So I have a build that was using "react-bootstrap-table": "^2.5.6",

Now it's started failing on me today..

ERROR in .//react-bootstrap-table/lib/toolbar/ToolBar.js
Module not found: Error: Cannot resolve module 'react-modal' in
.../client/node_modules/react-bootstrap-table/lib/toolbar
@ .//react-bootstrap-table/lib/toolbar/ToolBar.js 25:18-40

ERROR in ./~~/react-toastr/~~/react-dom/index.js
Module not found: Error: Cannot resolve module 'react/lib/ReactDOM' in
.../client/node_modules/react-toastr/node_modules/react-dom
@ ./~~/react-toastr/~~/react-dom/index.js 3:17-46

"react": "^15.3.2",
"react-addons-css-transition-group": "^15.3.2",
"react-bootstrap": "^0.30.3",
"react-bootstrap-table": "^2.5.6",
"react-datetime": "^2.6.0",
"react-dom": "^15.3.1",

On Tue, Nov 22, 2016 at 12:04 PM, Allen notifications@github.com wrote:

hi all, I've released v2.5.10, I think it could fix this issue, please
let me know if anything goes wrong. Any feedback is welcome :) thanks.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#838 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIFNJuVHUCNDG0nEu7iEBORxwKIWJyPks5rAyCGgaJpZM4K0Sl8
.

rahul1059 · 2016-11-29T04:06:41Z

@AllenFang I did following steps.

Removed react-bootstrap-table and installed v2.6.0.
Removed node modules and re installed everything with react-bootstrap-table v2.6.0

Both of these throwing same error.

Error: Cannot find module 'react-dom/lib/getVendorPrefixedEventName' from 'C:.....\node_modules\react-bootstrap-table\node_modules\react-toastr\node_modules\react\lib'

AllenFang · 2016-11-30T15:13:27Z

@rahul1059, I can reproduce it on npm@2 but not in npm@3. I'm still figure why in npm@2 the react-toastr which installed with react@15.4.1 instead of react@15.3.2. The problem still remain even I set perrDependencies like https://github.com/AllenFang/react-toastr/blob/test/react-version/package.json#L90

rahul1059 · 2016-12-06T04:47:34Z

@AllenFang Any update for npm@2?

AllenFang · 2016-12-06T16:02:48Z

Currently, I still figure out why, I know some solution, but no any solution is well. For now, after v2.6.0 only react@0.14.x with npm@2 still have issues. I'll keep to fix this remain problem. sorry for waiting a long time.

jamiguet · 2016-12-12T13:04:25Z

@AllenFang Are the changes going to be proposed to upstream and integrated into a version?
I have the problem that I build without access to the internet, so I need full releases so that my local repo can download them.

Please advise on toastr releases that integrate the fix you need.

olegserov · 2016-12-12T21:58:11Z

I had similar problem, what I did:
0. removed node_modules

installed npm3.
upgraded dependencies (see attached file)

looked at npm3 list and found " ERR! peer dep missing" ... react-dom.
npm3 install react-dom react-overlays react-prop-types --save-dev
Now it builds.

AllenFang · 2016-12-13T12:35:46Z

@jamiguet, is this #861 ? we are solving it. Need some time, a lots of thing need to do. Sorry ;(

af-fess · 2017-01-02T10:07:57Z

I still get the same issue, I use latest version 2.8.2 with dependancies:

  "react": "^0.14.7",
    "react-bootstrap": "^0.30.7",
    "react-bootstrap-table": "^2.8.2",
    "react-dom": "~0.14.7",

Inside react-bootstrap-table:

  "dependencies": {
    "classnames": "^2.1.2",
    "@allenfang/react-toastr": "2.8.2"
  },

Error in compilation in webpack: ModuleNotFoundError: 
Module not found:
 Error: Cannot resolve module 'react-dom/lib/getVendorPrefixedEventName' in /Users/.../client/node_modules/react-bootstrap-table/node_modules/@allenfang/react-toastr/node_modules/react/lib

/Users/.../client/webpack.vendors.config.js:56
                    throw new Error('Error in compilation in webpack: ' + stats.compilation.errors);

AllenFang · 2017-01-02T10:46:22Z

@af-fess, what's the version of npm and could you show me your node_modules by following command

npm list --depth=1 | grep react

BTW, could you remove the node_modules and install again?

af-fess · 2017-01-02T11:32:52Z

@AllenFang thanks for quick response

npm - 2.5.18

$ npm list --depth=1 | grep react
├─┬ babel-preset-react@6.16.0
│ ├── babel-plugin-transform-react-display-name@6.8.0
│ ├── babel-plugin-transform-react-jsx@6.8.0
│ ├── babel-plugin-transform-react-jsx-self@6.11.0
│ └── babel-plugin-transform-react-jsx-source@6.9.0
├─┬ react@0.14.8
├─┬ react-bootstrap@0.30.7
│ ├── react-overlays@0.6.10
│ ├── react-prop-types@0.4.0
├─┬ react-bootstrap-table@2.8.2
│ ├── babel-preset-react@6.16.0 extraneous
│ ├── eslint-plugin-react@3.6.3 extraneous
│ ├── react@15.4.1
│ ├── react-bootstrap@0.29.5 extraneous
│ ├── react-dom@15.4.1
│ ├── react-hot-loader@3.0.0-beta.6 extraneous
│ ├── react-router@3.0.0 extraneous
│ ├── react-toastr@2.8.2
├── react-dom@0.14.8
├─┬ react-hot-loader@3.0.0-beta.6
│ ├── react-deep-force-update@2.0.1
│ ├── react-proxy@3.0.0-alpha.1
│ ├── redbox-react@1.3.3
├─┬ react-router@2.8.1
│ ├── hoist-non-react-statics@1.2.0
├─┬ react-split-pane@0.1.57
│ └── react-style-proptype@1.4.0

also I tried to reinstall all node_modules, got the same error.

The problem is solved by updating react/react-dom to latest 15.4.1 that a cannot use for today (have a lot of deps)

ianks · 2017-01-18T02:33:45Z

@AllenFang Maybe we should just ditch react-toastr tbh. I don't see this issue being fixed anytime soon and its forcing us to be locked at older versions of React.

AllenFang · 2017-01-18T15:04:05Z

@ianks, yap, that issue still remain until now, actually I had tried the react-s-alert but it also have the same problem. Anyway, I'll try it again in recently, maybe I just got something wrong.

zekedroid · 2017-03-28T19:01:49Z

Any updates on this issue?

gengjiawen · 2017-04-10T02:41:39Z

Is it possible we remove this library and related function ?

AllenFang · 2017-04-10T12:31:41Z

I really want to remove it but it will be a big change

zekedroid · 2017-04-10T13:26:44Z

@AllenFang why not revert to a version of react-toaster that ISN'T using a scoped package. Why is the dependency listed with your scope? If it's because you forked and changed the library, maybe just change it to a different name so it doesn't clash? Or release an alpha version. Either way, this seems like it's not an issue with the library, just how it's being installed and depended on.

I know npm can be a pain, so maybe let us know what you've tried and we may be able to help!

AllenFang · 2017-04-11T15:39:33Z

please check #1216, if you have any concern or question, let me know in #1216

AllenFang · 2017-08-06T07:09:40Z

After v4.0.0, react-bootstrap-table doesn't use react-toastr` anymore.

AllenFang added the bug label Nov 17, 2016

gravitycode mentioned this issue Nov 21, 2016

Cannot resolve module getVendorPrefixedEventName #851

Closed

AllenFang closed this as completed in 8aa21f5 Nov 21, 2016

AllenFang reopened this Nov 22, 2016

vapon pushed a commit to vapon/react-bootstrap-table that referenced this issue Nov 22, 2016

(AllenFang#838) Limited react version to avoid toastr failure.

6a627e9

AllenFang mentioned this issue Nov 28, 2016

Install fails in restricted network environment (proxied npm registry) #861

Closed

AllenFang reopened this Nov 30, 2016

AllenFang mentioned this issue Dec 29, 2016

Allow latest version of react to be used AllenFang/react-toastr#1

Open

AllenFang mentioned this issue Jan 18, 2017

react-toastr version causing duplicate react packages in bundle #969

Closed

AllenFang mentioned this issue Feb 7, 2017

Is there a way to reset the table when prop changes? As in when the new data come in, i want the currPage to go back to 1 and remove the sorted table and so on. #975

Closed

AllenFang mentioned this issue Feb 18, 2017

how to remove toastr dependency #1054

Closed

AllenFang mentioned this issue Apr 4, 2017

react-addons-update #1191

Closed

AllenFang mentioned this issue Apr 11, 2017

Replace react-toastr with react-s-alert #1216

Closed

AllenFang closed this as completed Aug 6, 2017

react-toastr 2.8.2 breaking build #838

react-toastr 2.8.2 breaking build #838

Comments

aliabbas commented Nov 16, 2016

sgentile commented Nov 16, 2016

kellyi commented Nov 16, 2016

madeinfree commented Nov 17, 2016

kellyi commented Nov 17, 2016

AllenFang commented Nov 17, 2016 • edited Loading

gravitycode commented Nov 21, 2016

AllenFang commented Nov 21, 2016

mangreen commented Nov 22, 2016 • edited Loading

vapon commented Nov 22, 2016

gravitycode commented Nov 22, 2016

madeinfree commented Nov 22, 2016 • edited Loading

AllenFang commented Nov 22, 2016

vapon commented Nov 22, 2016

AllenFang commented Nov 22, 2016

AllenFang commented Nov 22, 2016

madeinfree commented Nov 22, 2016 • edited Loading

vapon commented Nov 22, 2016

kellyi commented Nov 22, 2016

kellyi commented Nov 22, 2016 • edited Loading

AllenFang commented Nov 22, 2016

AllenFang commented Nov 22, 2016

yschoueri commented Nov 22, 2016

Shaywei commented Nov 22, 2016 • edited Loading

qiusli commented Nov 22, 2016

sgentile commented Nov 22, 2016

rahul1059 commented Nov 29, 2016

AllenFang commented Nov 30, 2016

rahul1059 commented Dec 6, 2016

AllenFang commented Dec 6, 2016

jamiguet commented Dec 12, 2016

olegserov commented Dec 12, 2016 • edited Loading

AllenFang commented Dec 13, 2016

af-fess commented Jan 2, 2017

AllenFang commented Jan 2, 2017 • edited Loading

af-fess commented Jan 2, 2017 • edited Loading

ianks commented Jan 18, 2017

AllenFang commented Jan 18, 2017

zekedroid commented Mar 28, 2017

gengjiawen commented Apr 10, 2017

AllenFang commented Apr 10, 2017

zekedroid commented Apr 10, 2017

AllenFang commented Apr 11, 2017

AllenFang commented Aug 6, 2017

AllenFang commented Nov 17, 2016 •

edited

Loading

mangreen commented Nov 22, 2016 •

edited

Loading

madeinfree commented Nov 22, 2016 •

edited

Loading

madeinfree commented Nov 22, 2016 •

edited

Loading

kellyi commented Nov 22, 2016 •

edited

Loading

Shaywei commented Nov 22, 2016 •

edited

Loading

olegserov commented Dec 12, 2016 •

edited

Loading

AllenFang commented Jan 2, 2017 •

edited

Loading

af-fess commented Jan 2, 2017 •

edited

Loading