Fix pagination lost bug #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frontsideair, thanks, I'll review it 👍 |
|
@frontsideair, could you give me a example for showing this issues, I want to add and explain it on |
|
How about this? #233 It's almost the same as the gist I shared to test my error case, it's also illustrative for managing state outside the component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the order of preference for page and pagination size when receiving props. It would prefer nextProps over current page, which caused problems for me. It might work when you handle the selection inside the component, but as I'm giving this as a prop, it's triggered at times when it wasn't expected.
With this PR it'll prefer current page and pagination size over the ones provided by props.