Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use yarn, upgrade react-router v3, fixed issue #802

Merged
merged 5 commits into from
Nov 9, 2016

Conversation

madeinfree
Copy link
Contributor

@madeinfree madeinfree commented Oct 29, 2016

Hi @AllenFang,

Yarn install

This is PR with yarn and dependencies fix

Install yarn

> npm install yarn --global
> yarn

Fixed dependencies issue

React, React Bootstrap

use react version 15.3.0 cause PropTypes#7132 issue from react-bootstrap v0.29.5 so I upgrade react-bootstrap v0.30.0#2095 to resolve this issue.

React Router

I try to upgrade react-router to avoid history dependencies issue by version 3.0.0(link) which use history dependencies itself, so we can didn't care about history dependencies.

use

import { hashHistory } from 'react-router' 
//and add props into
<Router history={ hashHistory }>

now react-router 3.0.0 working fine.

Now dependencies version

  1. react-bootstrap v3.0.6
  2. react-router v3.0.0

Test working version

react, react-dom: 0.14.7, 15.0.0, 15.3.0 (all pass)

Have some suggestion feel free to discussion with me 👍

This was referenced Oct 29, 2016
@AllenFang
Copy link
Owner

@madeinfree, thanks a lot, it all look great for me but I still have few question about dependency, why move the react-bootstrap and history to dependencies section. In my opinion, react-bootstrap-table should not depend on these packages.

@madeinfree
Copy link
Contributor Author

@AllenFang sorry it my fault, I fixed the dependency

@AllenFang
Copy link
Owner

Very appreciated that you can still contribute this repo until now. :octocat:

@AllenFang AllenFang merged commit b87c11f into AllenFang:v3.0.0-dev Nov 9, 2016
@AllenFang
Copy link
Owner

Thanks your contribution 👍

@AllenFang
Copy link
Owner

#497

@sman591 sman591 mentioned this pull request May 3, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants