Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add history dependency #829

Merged
merged 2 commits into from
Nov 17, 2016
Merged

add history dependency #829

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491a4f9
add history dependency
Nov 15, 2016
9872d7e
moves history from dependencies to devDependencies
Nov 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
},
"dependencies": {
"classnames": "^2.1.2",
"history": "^1.17.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may not necessary for react-bootstrap-table, but example use it, maybe we can move it into devDependencies ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. BTW, This issue has been fixed on the branch of v3.0.0-dev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad @madeinfree I just pushed a commit with the requested changes.
@AllenFang Thank you for your hard work! Really looking forward to stable version of 3.0!

Copy link
Contributor

@madeinfree madeinfree Nov 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @bencooling 👍

"react-toastr": "^2.8.0"
},
"peerDependencies": {
Expand Down