Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OphysTimeAligner key loading for sync dataset #1513

Closed
2 tasks done
pickles-bread-and-butter opened this issue Apr 21, 2020 · 0 comments
Closed
2 tasks done

Fix OphysTimeAligner key loading for sync dataset #1513

pickles-bread-and-butter opened this issue Apr 21, 2020 · 0 comments
Assignees
@pickles-bread-and-butter
Labels
braintv relates to Insitute BrainTV program bug
Milestone
Pika 2020-05-06

Comments

@pickles-bread-and-butter
Copy link
Contributor

pickles-bread-and-butter commented Apr 21, 2020 •
edited
Loading

OphysTimeAligner loads incorrect keys for some sync files, evidenced by loading the wrong photodiode key for processing monitor delay.
New method needs to be implemented to search for key or throw an error if the data doesn't exist

ToDo:

  • Search for correct photodiode key in sync file (should be photodiode or stim_photodiode)
  • Add to list of non found keys and report keys not found to log file.
Closed
@wbwakeman wbwakeman added this to the Pika 2020-05-06 milestone Apr 22, 2020
@wbwakeman wbwakeman added the braintv relates to Insitute BrainTV program label Apr 23, 2020
pickles-bread-and-butter added a commit that referenced this issue Apr 24, 2020
@pickles-bread-and-butter
Updated the get_keys method to search for correct keys
cd2c2e7 
The get_keys method in time_sync.py was providing the wrong line labels
to the classes using the method. It was naively assuming that keys
existed in one set or the other with a clean division. This was not the
case and the issue was unveiled when error handling was removed from
monitor delay in #1438.

The method now searches for the possible key values and if they do not exist assumes an old file where not all keys are present. In the case of key not present it defaults to using the oldest key denoted in VERSION_1_KEYS. This fixes the failing bamboo tests and is a more robust search for the future.

Resolves: #1513
See also: #1438, #1519, #1451, #1507
pickles-bread-and-butter added a commit that referenced this issue Apr 24, 2020
@pickles-bread-and-butter
Updated the get_keys method to search for correct keys
dc09da3 
The get_keys method in time_sync.py was providing the wrong line labels
to the classes using the method. It was naively assuming that keys
existed in one set or the other with a clean division. This was not the
case and the issue was unveiled when error handling was removed from
monitor delay in #1438.

The method now searches for the possible key values and if they do not
exist assumes an old file where not all keys are present. In the case
of key not present it defaults to using the oldest key denoted in
VERSION_1_KEYS. This fixes the failing bamboo tests and is a more
robust search for the future.

Resolves: #1513
See also: #1438, #1519, #1451, #1507
pickles-bread-and-butter added a commit that referenced this issue Apr 29, 2020
@pickles-bread-and-butter
Merge pull request #1519 from AllenInstitute/GH-1513/bugfix/ophys_tim…
ace6d2d 
…e_aligner_sync_keys

Gh 1513/bugfix/ophys time aligner sync keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pickles-bread-and-butter pickles-bread-and-butter

Labels
braintv relates to Insitute BrainTV program bug
Projects
None yet
Milestone
Pika 2020-05-06
Development

No branches or pull requests
2 participants
@wbwakeman @pickles-bread-and-butter