Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize column name for auto reward across AllenSDK tables #1949

Closed
DowntonCrabby opened this issue Feb 24, 2021 · 2 comments
Closed

standardize column name for auto reward across AllenSDK tables #1949

DowntonCrabby opened this issue Feb 24, 2021 · 2 comments
Assignees
Labels
behavior braintv relates to Insitute BrainTV program enhancement

Comments

@DowntonCrabby
Copy link
Collaborator

DowntonCrabby commented Feb 24, 2021

AllenSDK returns tables with a column called either "auto_reward" or "autoreward" The science team would like to have a consistent name.

autoreward_naming

Describe the solution you'd like
I'd like the naming to be consistent across all table column names and dictionary keys.

I personally prefer using "auto_reward" because the pkl file returns an 'auto_reward_volume' so we'd be keeping the naming consistent across both the SDK and the pkl file, but this is just a preference. I don't really care which naming convention is used it is as long as it's consistent within the SDK tables and dictionaries.

Additional context
SDK 2.7.0

The following attributes mention auto rewards:
trials
rewards
task_parameters (in the future, see ticket #1515 )

@DowntonCrabby DowntonCrabby added enhancement behavior braintv relates to Insitute BrainTV program labels Feb 24, 2021
@wbwakeman
Copy link
Contributor

Per Marina, change the field in the rewards table to 'auto_rewards'

@DowntonCrabby
Copy link
Collaborator Author

DowntonCrabby commented Aug 17, 2021

@djkapner is this going to be part of the next iteration of the sdk release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior braintv relates to Insitute BrainTV program enhancement
Projects
None yet
Development

No branches or pull requests

4 participants