Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "autoreward_volume" key to session.task_parameters dictionary #1515

Closed
DowntonCrabby opened this issue Apr 22, 2020 · 4 comments
Closed
Assignees
Labels
behavior braintv relates to Insitute BrainTV program enhancement

Comments

@DowntonCrabby
Copy link
Collaborator

Describe the use case that is addressed by this feature.
currently the task_parameters dictionary only has a "reward_volume" key, whose value is 0.007, however we also have autorewards at the beginning and throughout the session, and the autoreward volume is 0.005, so it is important to record that information somewhere as well.

Describe the solution you'd like
add a "autoreward_volume" key with the value "0.005" to the dictionary

Describe alternatives you've considered
Any alternative solutions or features you've considered.

@DowntonCrabby DowntonCrabby changed the title add "auto_reward" key to session.task_parameters dictionary add "autoreward_volume" key to session.task_parameters dictionary Apr 22, 2020
@wbwakeman wbwakeman added behavior braintv relates to Insitute BrainTV program labels Apr 23, 2020
@danielsf danielsf self-assigned this Feb 24, 2021
@danielsf
Copy link
Contributor

@DowntonCrabby because naming things is hard:

you want autoreward_volume not auto_reward_volume?

(the latter is how it's listed in the pickle file, prompting me to ask)

danielsf added a commit that referenced this issue Feb 24, 2021
@danielsf danielsf mentioned this issue Feb 24, 2021
12 tasks
@DowntonCrabby
Copy link
Collaborator Author

@danielsf lets do autoreward_volume

I will also open another ticket to unify the naming related to autorewards.
currently dataset.rewards has "autorewarded" and dataset.trials has "auto_rewarded" so the trials attribute column name will need to be updated from "auto_rewarded" to "autorewarded"

@danielsf
Copy link
Contributor

Cool

(also 🤦 in reaction to your second paragraph)

@DowntonCrabby
Copy link
Collaborator Author

actually @danielsf lets do auto_reward_volume , that way it's consistent with the pkl file as well. I only preferred "autoreward" for brevity sake, which seems silly. Sorry to flip flop like that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior braintv relates to Insitute BrainTV program enhancement
Projects
None yet
Development

No branches or pull requests

3 participants