GH 1357: Project caches should not accept arbitrary kwargs #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
requested review from
NileGraddis,
njmei and
sgratiy
as code owners
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Codecov Report
@@ Coverage Diff @@
## rc/1.5.0 #1373 +/- ##
============================================
+ Coverage 34.53% 34.54% +0.01%
============================================
Files 342 342
Lines 33231 33262 +31
============================================
+ Hits 11475 11492 +17
- Misses 21756 21770 +14
Continue to review full report at Codecov.
|
NileGraddis
reviewed
Feb 20, 2020
kschelonka
force-pushed
the
GH-1347/cache-kwarg-fix
branch
3 times, most recently
from
95516df to
ffea826
Compare
njmei
reviewed
Mar 5, 2020
njmei
reviewed
Mar 5, 2020
Accepting arbitrary kwargs led to confusion for scientists accidentally passing incorrect keywords. This PR removes the ability to pass arbitrary kwargs to public Project cache constructors, to reduce the possibility of silent errors.
kschelonka
force-pushed
the
GH-1347/cache-kwarg-fix
branch
from
ffea826 to
4350828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting arbitrary kwargs led to confusion for scientists
accidentally passing incorrect keywords. This PR removes
the ability to pass arbitrary kwargs to public Project cache
constructors, to reduce the possibility of silent errors.
In addition to unit-testing I ran quick notebook examples with all the different constructors (fixed, warehouse, lims, etc.). In doing so I noticed a typo in the keyword-argument of the ecephys example, and a failure in the behavior project cache notebook due to an oversight about which ID is used.