Fixed bug requiring additional IDs for BehaviorDataLimsApi #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously BehaviorDataLimsApi would raise an exception if no container id was returned from lims id for given ophys id. This has been changed at allenskd/internal/api/behavior_data_lims_api.py 105 - 108. Now the query will return None for the container id if the query results in an empty list return. Resolves: #1354
pickles-bread-and-butter
requested review from
kschelonka,
NileGraddis,
njmei and
sgratiy
as code owners
Codecov Report
@@ Coverage Diff @@
## rc/1.5.0 #1374 +/- ##
============================================
- Coverage 34.55% 34.54% -0.01%
============================================
Files 342 342
Lines 33250 33255 +5
============================================
Hits 11488 11488
- Misses 21762 21767 +5
Continue to review full report at Codecov.
|
|
Also please update to return None instead of an empty list if there are no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously BehaviorDataLimsApi would raise an exception if no container id
was returned from lims id for given ophys id. This has been changed at
allenskd/internal/api/behavior_data_lims_api.py 105 - 108. Now the query will
return None for the container id if the query results in an empty list return.
Resolves: #1354