Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecephys optotagging tutorial #1375

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

jsiegle
Copy link
Collaborator

@jsiegle jsiegle commented Feb 20, 2020

Add new ecephys notebook, and add link to docs page

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@jsiegle
Copy link
Collaborator Author

jsiegle commented Feb 20, 2020

I rebased to rc/1.5.0, but it looks like Travis build is still failing...did I do something wrong?

@wbwakeman wbwakeman added braintv relates to Insitute BrainTV program neuropixels labels Feb 24, 2020
@kschelonka kschelonka changed the base branch from rc/1.5.0 to rc/1.6.0 February 24, 2020 20:07
@kschelonka
Copy link
Contributor

Closing and reopening to trigger build on new target branch.

@kschelonka kschelonka closed this Feb 24, 2020
@kschelonka kschelonka reopened this Feb 24, 2020
@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #1375 into rc/1.6.0 will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc/1.6.0    #1375      +/-   ##
============================================
+ Coverage     34.55%   34.64%   +0.09%     
============================================
  Files           342      342              
  Lines         33250    33552     +302     
============================================
+ Hits          11488    11625     +137     
- Misses        21762    21927     +165
Impacted Files Coverage Δ
allensdk/internal/api/behavior_data_lims_api.py 53% <0%> (-1.38%) ⬇️
allensdk/core/authentication.py 97.67% <0%> (+2.32%) ⬆️
allensdk/brain_observatory/sync_dataset.py 27.73% <0%> (+4.8%) ⬆️
...lensdk/brain_observatory/behavior/sync/__init__.py 44.44% <0%> (+18.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a647ad...c3a83a9. Read the comment docs.

@kschelonka
Copy link
Contributor

Hi @jsiegle, sorry about the build issues. Your rebase was correct -- the issue was on forks not being able to access Travis variables we'd set.

@kschelonka kschelonka merged commit 35aec61 into AllenInstitute:rc/1.6.0 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
braintv relates to Insitute BrainTV program neuropixels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants