Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cache_spec==True keyword to lfp_writer.write call #1427

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

pickles-bread-and-butter
Copy link
Contributor

NWB advises to include this keyword in the NWB file write. This keyword caches the extension in the NWB file so it's easier for others to read data. No need to import ecephys.nwb.

NWB advises to include this keyword in the NWB file write. This keyword caches the extension in the NWB file so it's easier for others to read data. No need to import ecephys.nwb.
@codecov-io
Copy link

Codecov Report

Merging #1427 into rc/1.6.0 will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc/1.6.0    #1427      +/-   ##
============================================
+ Coverage     34.59%   34.71%   +0.11%     
============================================
  Files           342      342              
  Lines         33243    33253      +10     
============================================
+ Hits          11501    11544      +43     
+ Misses        21742    21709      -33     
Impacted Files Coverage Δ
...dk/brain_observatory/ecephys/write_nwb/__main__.py 67.59% <100.00%> (+0.23%) ⬆️
allensdk/internal/api/behavior_data_lims_api.py 52.84% <0.00%> (-1.55%) ⬇️
...ephys/stimulus_analysis/receptive_field_mapping.py 89.01% <0.00%> (-0.44%) ⬇️
...dk/brain_observatory/behavior/trials_processing.py 24.46% <0.00%> (-0.07%) ⬇️
allensdk/internal/api/behavior_ophys_api.py 28.93% <0.00%> (+0.21%) ⬆️
...brain_observatory/ecephys/copy_utility/__main__.py 63.52% <0.00%> (+0.43%) ⬆️
allensdk/internal/brain_observatory/time_sync.py 24.84% <0.00%> (+24.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba72143...057b955. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants