1419 nwb ecephys probe as device #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rly Would love to get any feedback from nwb folks before asking for internal feedback. |
|
Hi @bendichter I just wanted to see if you or @rly had any other comments/suggestions before I proceed with merging this PR. |
|
@njmei sorry for the delayed response lately. Both @rly and I are very interested in helping with this but you are catching us days before our big annual user training workshop. You've done a great job. From a quick look I can say this is a huge improvement! Ryan and I will schedule a time to look at this in detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to address #1419, #1423, and parts of #1530
I had hoped to address #1421 in this PR as well, but it looks like there is not currently a way to store both
ElectricalSeriestimestamps together with samplingrate.CC: @bendichter @rly