Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1076 remove ecephys warehouse structure assignment patch #1562

Merged
merged 2 commits into from
May 18, 2020
Merged

1076 remove ecephys warehouse structure assignment patch #1562

merged 2 commits into from
May 18, 2020

Conversation

njmei
Copy link
Contributor

@njmei njmei commented May 6, 2020 •
edited
Loading

  • Wait for test warehouse to be updated with correct ecephys_channel manual_structure_ids

  • Prior to merging, ensure that the following ecephys_channels have the correct manual_structure_ids when performing RMA query from updated warehouse:

733744647
733744649
733744651
733744653
733744655
805579698
832129149
837761710

njmei added 2 commits May 6, 2020 16:52
@njmei
Remove ecephys warehouse structure assignment patch
982e487 
Previously, #1072 introduced a patch to fix incorrect structure
assignments for some ecephys channels. Now that these structure
assignments are fixed, this patch is now unnecessary.

Relates to: #1076
@njmei
Fix linter errors
383542d
@njmei njmei force-pushed the 1076-remove-ecephys-warehouse-structure-assignment-patch branch from 9375fba to 383542d Compare May 6, 2020 23:53
@wbwakeman wbwakeman added the braintv relates to Insitute BrainTV program label May 7, 2020
NileGraddis
NileGraddis approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@NileGraddis NileGraddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@njmei njmei merged commit d21be1f into feature/update-pynwb-and-hdmf May 18, 2020
@njmei njmei deleted the 1076-remove-ecephys-warehouse-structure-assignment-patch branch May 18, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NileGraddis NileGraddis NileGraddis approved these changes

@kschelonka kschelonka Awaiting requested review from kschelonka

@sgratiy sgratiy Awaiting requested review from sgratiy

Assignees
No one assigned
Labels
braintv relates to Insitute BrainTV program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njmei @NileGraddis @wbwakeman