Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vbn nwb writer #2372

Merged
merged 6 commits into from
Apr 22, 2022
Merged

Vbn nwb writer #2372

merged 6 commits into from
Apr 22, 2022

Conversation

aamster
Copy link
Contributor

@aamster aamster commented Apr 20, 2022

Addresses #2351

  • Adds script allensdk/brain_observatory/ecephys/write_nwb/vbn/__main__.py to generate nwb files for VBN
  • Refactors input schemas to reuse existing
  • Adds NwbWriter class to handle writing nwb to reduce code duplication amongst write nwb scripts
  • Add ability to skip bad probes

Manually tested that NWB file was generated successfully.

aamster added 3 commits April 20, 2022 16:12
Refactor schemas to share code
introduces NWBWriter that abstracts code needed to write nwb
@aamster aamster marked this pull request as ready for review April 20, 2022 22:17
…nSDK into vbn_nwb_writer

# Conflicts:
#	allensdk/brain_observatory/ecephys/behavior_ecephys_session.py
#	allensdk/test/brain_observatory/ecephys/test_probes.py
@aamster aamster merged commit cb59b50 into vbn_2022_dev Apr 22, 2022
@aamster aamster deleted the vbn_nwb_writer branch April 22, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants