Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unnecessary validation on non-behavior files #2389

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Conversation

aamster
Copy link
Contributor

@aamster aamster commented Apr 25, 2022

Addresses #2382

  • Removes unnecessary check on non-behavior stimulus files
  • Removes _NumFramesMixin as this logic can just be part of StimulusFile
  • Make num_frames a property rather than a method
  • Updates NWB input schema to remove running speed inputs

Validation:

  • Tested on a single session that previously failed due to this validation check. It now fails for a different known issue.

@aamster aamster marked this pull request as ready for review April 25, 2022 21:53
@aamster aamster changed the title Ticket/2382 Removes unnecessary validation on non-behavior files Apr 25, 2022
@aamster aamster requested a review from danielsf April 25, 2022 21:54
Copy link
Contributor

@danielsf danielsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks

@aamster aamster merged commit e3d4fc9 into vbn_2022_dev Apr 25, 2022
@aamster aamster deleted the ticket/2382 branch April 25, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants