Vbn 2022 dev #2435
Merged
Vbn 2022 dev #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves data object base classes out of behavior
We are going to need to implement different varieties of StimulusFile sub-classes to represent the other pickle files involved in the VBN data. I did not want any VBO code to accidentally use these new classes.
each has its own way of access num_frames and its own dict_repr key for use in from_json and to_json all inherity from _StimulusFile base class
Note: ended up wrapping test clean up code in try/except block the windows CI processes are still getting PermissionErrors cleaning up temporary files. That should not block building/deploying make sure string gets passed to safe_system_path
between frame times read from the sync file and eye tracking frames. The solution is to drop frame times corresponding to the dropped frames.
Probes data object
…nSDK into ecephys_data_objects3 # Conflicts: # allensdk/brain_observatory/ecephys/ecephys_session_api/ecephys_nwb_session_api.py # allensdk/brain_observatory/ecephys/write_nwb/__main__.py
Adds optotagging table data object
Add DataFile kwargs optoin. Modify SyncFile to use permissive keyword.
…ulus presentations code with Presentations class
Makes Presentations class compatible with VBN
…efore writing it to NWB. Moves code from nwb to Templates class
Add ability to write stimulus templates to NWB for VBN
add behavior ecephys metadata
…nSDK into ticket/2357/multi/stim/timestamps
this will allow us to properly reconstruct the mouse's history as it passes through our apparatus
except waveform_duration and waveform_halfwidth
(necessary to maintain backwards combatibility with VCN)
…ields Ticket/2454/rename/vbn/fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just creating this pull request so that all of the checks involved can be run on
vbn_2022_devas we add to it, just in case.I am not claiming we are ready to merge this beast, yet.