Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase lower bound on jinja2 #2481

Merged
merged 1 commit into from
Jun 21, 2022
Merged

increase lower bound on jinja2 #2481

merged 1 commit into from
Jun 21, 2022

Conversation

aamster
Copy link
Contributor

@aamster aamster commented Jun 21, 2022

Addresses #2478

Jinja2 is a dependency of allensdk. It has a dependency called Markupsafe, and only specifies a lower bound of 0.2.3 even though it really requires < 2.1.1. Markupsafe 2.1.1 was getting installed.

Apparently they didn't fix it because jinja2 2.x is not supported.

Increase lower bound to 3.x.

@aamster aamster marked this pull request as ready for review June 21, 2022 20:16
@aamster aamster requested a review from morriscb June 21, 2022 20:16
Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I remember hitting this issue as well when we did a release. Upped the jinja a bit but apparently not enough for the long term.

@aamster aamster merged commit 5aa93e5 into rc/2.13.5 Jun 21, 2022
@aamster aamster deleted the ticket/2478 branch June 21, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants