Update vbn quality metrics tutorial #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add note highlighting change in default sdk behavior: we now return all units without filtering.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
aamster
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR adds a note in the first markdown cell of the VBN quality metrics tutorial to warn users that the VBN SDK returns all units by default, without applying filters as was done with VCN. It also fixes several typos in subsequent markdown cells.
Type of Fix:
functionality to not work as expected)
Solution:
Edited the text in several markdown cells.
Changes:
-added note at top of notebook
-deleted misleading sentence about raw data being available
-fixed 2 text typos
Validation:
All edited cells run as expected.