Ticket/PSB-249: Address comments on final release candidate. #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aamster
approved these changes
Oct 20, 2023
morriscb
force-pushed
the
ticket/PSB-249/dev
branch
2 times, most recently
from
ba0c873 to
6e75122
Compare
Add project codes to stim processing. Switch trials_id calculation to not require stimulus_block. Remove x,y,heigh,width Update change log Update cells table. Clean up and format cache warning message. Update change log with counts and comment suggestions. Remove incorrect information. Update numbers and image in visual behavior documentation. Change bucket location to test rc notebooks against new data (temporary for testing).
morriscb
force-pushed
the
ticket/PSB-249/dev
branch
from
35c656d to
f1ae5ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @matchings comments on final release candidate.
Remove x,y,height,width from cells table.
Add warning regarding new stimulus_presentations to VBO cache object.
Reset compatibility for final release (was temporarily changed)
Add descriptions of new stimulus_presentations and trials columns to numpydoc string.
Add typing for movie_repeat.
Move trials_id calculation up to allow it to be added to previous datasets with no (read one) stimulus block.
Add development project_codes to stimulus_block_name lookup allowance as some of these sessions are part of the release.
Expound on Change Log for data.