Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SweepFormula: Add formula for spontaneous PSC detection (PSX) #1313

Closed
t-b opened this issue Mar 22, 2022 · 5 comments · Fixed by #1468
Closed

SweepFormula: Add formula for spontaneous PSC detection (PSX) #1313

t-b opened this issue Mar 22, 2022 · 5 comments · Fixed by #1468
Assignees
Labels
enhancement New feature or request Miniature Analysis aka PSX PSP/PSC, part of SweepFormula SweepFormula

Comments

@t-b
Copy link
Collaborator

t-b commented Mar 22, 2022

  • Sweep data in IC
  • Filter data to reduce noise
  • Deconvolute, see PA plot code
  • FindLevel for finding the events
  • User needs a persistent way to reject events via GUI. Event rejection is per sweep
  • Visualize accepted/rejected events with colored circle

Output:

  • Absolute time of events
  • Amplitude (from filtered data, not from the deconvoluted data)
  • Maybe more later

See also https://docs.google.com/document/d/1oCx1l-M0SApEcEsPPfIO5iWFk_TENieX9CZ9Tb5i0Io

Have a look how http://www.neuromatic.thinkrandom.com/ does it.

Example data is on the FTP in the folder 2022-03-08 PSC example data.

  • Keep the reject/accept state machine readable for machine learning later on
@t-b t-b added enhancement New feature or request SweepFormula labels Mar 22, 2022
@t-b t-b self-assigned this Aug 10, 2022
@t-b
Copy link
Collaborator Author

t-b commented Aug 19, 2022

Meeting with Travis today had the following outcome. The questions were my questions.


Q: Is everything important plotted? I.e. Do you need more info to decide on accepted/rejected?
A: Yes all plotted. Nothing additional for now.

Q: Is there a default (accepted/rejected/undecided) for each event?
A: start with accepted, no undecided

Q: How should we implement the UX for peak acceptance/rejection?
One could make clicking the marker toggle the state. I would also use a non-filled circle.
A: - Toggle state with Ctrl+Mouse click on event.

  • Allow to use marquee with custom menu entries as well to change a range of events.
  • Add keyboard control (request from @timjarsky) to do it without mouse and minimum key strokes. Add back button. Automatic jump to next.

Q: tau_d/tau_r are currently not calculated. Should they?
A: Not now.

Q: Does it make sense to plot the events on the deconvoluted data?
A: Yes makes sense.

Q: Should we plot the raw data close as well?
A: No, but plot filtered data, as already done, scale to visible, mark events in that as well

Additional plots to see how it evolves with the sweeps:

  • Number of events per sweep (one for each accepted/rejected)
  • Averaged amplitude of all accepted events per sweep

No export in NWBv2 data structures for now.

Tunable parameters:

  • Deconvolution kernel
  • find_crossings: thresh
  • time to ignore at end of trace
  • filter_sweep: low/high (optional)

Time range:

  • Always ignore inserted TP

I said I come up with a first SF draft in around 2 weeks.

@t-b
Copy link
Collaborator Author

t-b commented Oct 19, 2022

@timjarsky #MissingTravisMentioning

So I came up with a draft of the UI and the SF interface. See the attached experiment:
Graph2.zip

For convenience here is the graph:

grafik

The keyboard controls for acceptance/rejectance is partly already working. I did that so that we can get a feeling if this is going in the right direction.

I'm available for a chat today.

@t-b
Copy link
Collaborator Author

t-b commented Oct 24, 2022

Comment from @MichaelHuth:

As for the special plot: Instead of looking for the last operation I think it is
better to use the meta data like SF_META_DATATYPE.
Or to introduce a new field for the wRef wave like SF_META_PLOTTYPE that a operation
can set.

@t-b t-b changed the title SweepFormula: Add formula for spontaneous PSC detection SweepFormula: Add formula for spontaneous PSC detection (EPSP) Oct 24, 2022
@t-b
Copy link
Collaborator Author

t-b commented Oct 24, 2022

@travis-open See #1313 (comment).

@t-b
Copy link
Collaborator Author

t-b commented Oct 26, 2022

From https://aiephys.slack.com/archives/D0388H0EVDJ/p1666717915656869:

We can assume analysis/visualization of one HS at a time.

@t-b t-b added the Miniature Analysis aka PSX PSP/PSC, part of SweepFormula label Mar 13, 2023
@t-b t-b changed the title SweepFormula: Add formula for spontaneous PSC detection (EPSP) SweepFormula: Add formula for spontaneous PSC detection (PSX}) Mar 31, 2023
@t-b t-b changed the title SweepFormula: Add formula for spontaneous PSC detection (PSX}) SweepFormula: Add formula for spontaneous PSC detection (PSX) Mar 31, 2023
@t-b t-b closed this as completed in #1468 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Miniature Analysis aka PSX PSP/PSC, part of SweepFormula SweepFormula
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant