Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataConfigurationResult: Rename member DAGains #1873

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Sep 5, 2023

It holds the gain values for all channels and not only for DAGains so let's rename it. Bug introduced in fac268c (Acquisition support for NI DAC devices in multi device mode, 2018-08-03).

Close #1823

Will merge once CI passes.

It holds the gain values for all channels and not only for DAGains so
let's rename it. Bug introduced in fac268c (Acquisition support for NI
DAC devices in multi device mode, 2018-08-03).

Close #1823
@t-b t-b self-assigned this Sep 5, 2023
@t-b t-b requested a review from timjarsky as a code owner September 5, 2023 17:54
@t-b t-b merged commit d596084 into main Sep 6, 2023
16 checks passed
@t-b t-b deleted the bugfix/1873-rename-dagain branch September 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataConfigurator: rename or split DAGain wave
1 participant