Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates #1875

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Various updates #1875

merged 7 commits into from
Sep 8, 2023

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Sep 5, 2023

No description provided.

@t-b t-b requested a review from timjarsky as a code owner September 5, 2023 18:55
This was linked to issues Sep 5, 2023
Update SF notebook for https://github.com/AllenInstitute/MIES/pull/1822 #1827
Closed
SweepFormula: Remove outdated documentation #1842
Closed
Documentation: Document the average color in the relevant colors table #1838
Closed
Add more sweepformula examples #1843
Closed
@t-b

This comment was marked as outdated.

Sign in to view
@t-b t-b assigned t-b and unassigned timjarsky Sep 7, 2023
t-b added 5 commits September 7, 2023 18:03
@t-b
SweepFormula.ifn: Add missing text from #1822
8e6d9e7 
Adding the text was postponed to avoid merge conflicts with #1468.

Close #1827.
@t-b
SweepFormula.rst: Enhance documentation for channels operation
45a00bd 
It is important to know which channels the user needs to input.
@t-b
developers.rst: Remove outdated SweepFormula implementation definition
a651b44 
This reverts commit 57fbacb (Developer docu: Add original sweepformula notes from Matthias, 2021-11-19).

Since the move to the new dataset approach in 1b7c17a (SF: Change +
operation to use permanent wref waves in working df, 2022-05-13) that is
not needed anymore.

Close #1842.
@t-b
MIES_Regenerate-Screenshots.ipf: Undust for relevant colors graph rec…
dd117c1 
…reation
@t-b
MIES_Regenerate-Screenshots.ipf: Move to ipf folder
0a5a8be 
In that way this is compile tested.
@t-b t-b force-pushed the bugfix/1875-update-sweepformula-notebook branch 2 times, most recently from 7882f39 to 5cc86b3 Compare September 7, 2023 16:06
t-b added 2 commits September 7, 2023 18:07
@t-b
Packages/doc/ScreenShots: Update RelevantColors.png
b4f0337 
We now document the average color, the independent color and also make the
TTL colors more self explanatory.

Close #1838.
@t-b
SweepFormula: Add examle with fancy epoch extraction
5aee08b 
Close #1843.
@t-b t-b force-pushed the bugfix/1875-update-sweepformula-notebook branch from 5cc86b3 to 5aee08b Compare September 7, 2023 16:07
@t-b
Copy link
Collaborator Author

t-b commented Sep 7, 2023

@timjarsky Done.

@t-b t-b assigned timjarsky and unassigned t-b Sep 7, 2023
@t-b t-b enabled auto-merge September 7, 2023 16:48
@timjarsky timjarsky assigned t-b and unassigned timjarsky Sep 7, 2023
@t-b t-b merged commit a199c63 into main Sep 8, 2023
16 checks passed
@t-b t-b deleted the bugfix/1875-update-sweepformula-notebook branch September 8, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky timjarsky approved these changes

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@t-b @timjarsky