Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted parts from #1860 #1879

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Extracted parts from #1860 #1879

merged 5 commits into from
Sep 7, 2023

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Sep 6, 2023

Will merge once CI passes.

@t-b
MIES_SweepFormula_PSX.ipf: Rename filterLow/filterHigh to sweepFilter…
a1db6f5 
…Low/sweepFilterHigh

In a future commit we want to add more filter parameters so having a
better fitting name makes things easier.
@t-b
SFH_GetArgumentAsNumeric/SFH_GetArgumentAsText: Add optional checkDef…
0ff5782 
…ault parameter

That parameter, on by default, allows to turn of the validity checks when
the default value is used. The use case is to allow the default value to
be invalid so that the operation knows that the default value was passed.
@t-b
Packages/MIES: Move SFH_GetXXX check functions to a separate file
db2f742
@t-b
Tests: Add some for IsStrictlyPositiveAndFinite
630066d
@t-b
IsNullOrPositiveAndFinite: Add it with tests
b388d7d
@t-b t-b requested a review from timjarsky as a code owner September 6, 2023 17:22
@t-b t-b self-assigned this Sep 6, 2023
@t-b t-b merged commit 0de9ec0 into main Sep 7, 2023
16 checks passed
@t-b t-b deleted the feature/1879-various-updates branch September 7, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-b