Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change metric type of LocalCacheState from counter to gauge #18070

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Change metric type of LocalCacheState from counter to gauge #18070

merged 1 commit into from
Sep 8, 2023

Conversation

maobaolong
Copy link
Contributor

@maobaolong maobaolong commented Aug 28, 2023 •
edited
Loading

What changes are proposed in this pull request?

Change metric type of LocalCacheState from counter to gauge.

Why are the changes needed?

The type of LocalCacheState metric is not reasonable since the value of this metric is a enum type not an increasable value

Does this PR introduce any user facing changes?

No

@maobaolong maobaolong requested a review from apc999 August 28, 2023 11:59
jiacheliu3
jiacheliu3 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@jiacheliu3 jiacheliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@jiacheliu3 jiacheliu3 added the type-debt This issue is about tech debt label Sep 8, 2023
@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 6a0e1c5 into Alluxio:main Sep 8, 2023
12 checks passed
@jiacheliu3 jiacheliu3 mentioned this pull request Sep 8, 2023
Merged
alluxio-bot pushed a commit that referenced this pull request Sep 8, 2023
@jiacheliu3
Revert "Change metric type of LocalCacheState from counter to gauge"
72de4e9 
Reverts #18070
revert per request on backward compatibility
			pr-link: #18119
			change-id: cid-aeecbff3bc9d6bff41eec25405e87a2f2b79079f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacheliu3 jiacheliu3 jiacheliu3 approved these changes

@apc999 apc999 Awaiting requested review from apc999

Assignees
No one assigned
Labels
type-debt This issue is about tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maobaolong @jiacheliu3 @alluxio-bot