Make fuse max reader concurrency configurable #18129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbw9580
reviewed
Sep 12, 2023
dbw9580
reviewed
Sep 12, 2023
dbw9580
reviewed
Sep 12, 2023
Comment on lines
+8267
to
+8268
| public static final String FUSE_MAX_READER_CONCURRENCY = | ||
| "alluxio.max.fuse.reader.concurrency"; |
There was a problem hiding this comment.
typo? I think the convention is to keep the string literal property name the same as the constant's name.
Suggested change
| public static final String FUSE_MAX_READER_CONCURRENCY = | |
| "alluxio.max.fuse.reader.concurrency"; | |
| public static final String FUSE_MAX_READER_CONCURRENCY = | |
| "alluxio.fuse.max.reader.concurrency"; |
dbw9580
approved these changes
Sep 12, 2023
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make fuse max reader concurrency configurable. The default value was 64 and it was unchangeable.