Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover the ufs uri support #18135

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Recover the ufs uri support #18135

merged 1 commit into from
Sep 15, 2023

Conversation

beinan
Copy link
Contributor

@beinan beinan commented Sep 12, 2023

What changes are proposed in this pull request?

Recover the ufs uri support

Why are the changes needed?

Ufs uri should be the first class citizen in dora

Does this PR introduce any user facing changes?

No

@Jackson-Wang-7
Copy link
Contributor

Would you like to support using UFS uri directly in this PR? it will construct the specified UFS based on the root mount in the config file in there https://github.com/Alluxio/alluxio/blob/main/dora/core/client/fs/src/main/java/alluxio/client/file/ufs/UfsBaseFileSystem.java#L108. if the request uri is not matched with the root mount, it may fail. we may need to use the request URI to construct the UFS instance if we want to access UFS uri directly.

@beinan
Copy link
Contributor Author

beinan commented Sep 13, 2023

Would you like to support using UFS uri directly in this PR? it will construct the specified UFS based on the root mount in the config file in there https://github.com/Alluxio/alluxio/blob/main/dora/core/client/fs/src/main/java/alluxio/client/file/ufs/UfsBaseFileSystem.java#L108. if the request uri is not matched with the root mount, it may fail. we may need to use the request URI to construct the UFS instance if we want to access UFS uri directly.

Yes, let's post another PR to fix it

@beinan beinan force-pushed the recover_ufs_uri_support branch from cba94d4 to b65c28c Compare September 13, 2023 23:20
@beinan beinan added the type-debt This issue is about tech debt label Sep 15, 2023
@beinan
Copy link
Contributor Author

beinan commented Sep 15, 2023

alluxio-bot, merge this please.

@alluxio-bot alluxio-bot merged commit 100eb4f into Alluxio:main Sep 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apc999 apc999 apc999 approved these changes

Assignees
No one assigned
Labels
type-debt This issue is about tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beinan @Jackson-Wang-7 @apc999 @alluxio-bot