Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCFIX] Fix check-docs errMsg bug #18138

Merged
merged 3 commits into from
Sep 14, 2023
Merged

[DOCFIX] Fix check-docs errMsg bug #18138

merged 3 commits into from
Sep 14, 2023

Conversation

Zijian-Zhu
Copy link
Contributor

No description provided.

@Zijian-Zhu Zijian-Zhu requested a review from Xenorith September 13, 2023 00:02
Xenorith
Xenorith reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Xenorith Xenorith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change shouldn't be necessary. slice variables (and also map variables) are pointers so this change to pass the pointer reference to the function should have no effect; actually now you're passing the pointer to the pointer to the underlying slice.

@Zijian-Zhu Zijian-Zhu added the type-docs Documentation Defects label Sep 14, 2023
@Zijian-Zhu
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 7fc1040 into Alluxio:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenorith Xenorith Xenorith approved these changes

Assignees
No one assigned
Labels
type-docs Documentation Defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zijian-Zhu @Xenorith @alluxio-bot