Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of proxy host #18142

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

Jackson-Wang-7
Copy link
Contributor

@Jackson-Wang-7 Jackson-Wang-7 commented Sep 13, 2023

What changes are proposed in this pull request?

If don't set oss.proxy.host, the default value should be NULL

Why are the changes needed?

If don't set oss.proxy.host, the default value should be NULL

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

@Jackson-Wang-7 Jackson-Wang-7 added the type-bug This issue is about a bug label Sep 13, 2023
Copy link
Contributor

@jiacheliu3 jiacheliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 1f146a9 into Alluxio:main Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants