Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken PagedDoraWorkerTest #18150

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

YichuanSun
Copy link
Contributor

What changes are proposed in this pull request?

Fix the broken PagedDoraWorkerTest.

Why are the changes needed?

The old test is.broken, I just fix it.

Does this PR introduce any user facing changes?

no.

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("Ut") is not an imperative verb. Please use one of the valid words
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@YichuanSun YichuanSun changed the title Ut paged dora worker test fix Fix the broken PagedDoraWorkerTest Sep 14, 2023
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

@YichuanSun YichuanSun added the type-code-quality code quality improvement label Sep 14, 2023
@YichuanSun YichuanSun requested review from jja725 and elega and removed request for jja725 September 14, 2023 08:09
Copy link
Contributor

@jiacheliu3 jiacheliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@YichuanSun YichuanSun force-pushed the UT-PagedDoraWorkerTestFix branch 2 times, most recently from daaab16 to 06fefa6 Compare September 18, 2023 08:26
@YichuanSun YichuanSun closed this Sep 18, 2023
@YichuanSun YichuanSun force-pushed the UT-PagedDoraWorkerTestFix branch from 06fefa6 to 838893d Compare September 18, 2023 08:28
@YichuanSun YichuanSun reopened this Sep 18, 2023
@YichuanSun YichuanSun force-pushed the UT-PagedDoraWorkerTestFix branch from bd9504c to 06fefa6 Compare September 18, 2023 09:00
@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit d737d56 into Alluxio:main Sep 19, 2023
12 checks passed
@YichuanSun YichuanSun deleted the UT-PagedDoraWorkerTestFix branch October 9, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-code-quality code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants