Add UT to DefaultPageMetaStore.commitFile #18162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YichuanSun
changed the title
jiacheliu3
reviewed
Sep 26, 2023
dora/core/client/fs/src/test/java/alluxio/client/file/cache/DefaultPageMetaStoreTest.java
Show resolved
Hide resolved
jiacheliu3
approved these changes
Oct 7, 2023
dora/core/client/fs/src/test/java/alluxio/client/file/cache/QuotaPagePageMetaStoreTest.java
Outdated
Show resolved
Hide resolved
jiacheliu3
changed the title
|
alluxio-bot, merge this please |
ssz1997
pushed a commit
to ssz1997/alluxio
that referenced
this pull request
Dec 15, 2023
### What changes are proposed in this pull request? Add unit test for DefaultPageMetaStore.commitFile() method, and rename some variables to more accurate names. ### Why are the changes needed? Improve the test coverage. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#18162 change-id: cid-e7de0d5b474d36b67c85f0ed0a49202a37dc7194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add unit test for DefaultPageMetaStore.commitFile() method, and rename some variables to more accurate names.
Why are the changes needed?
Improve the test coverage.
Does this PR introduce any user facing changes?
No.