Fix GCSV2UnderFileSystem initialization #18184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyge2022
reviewed
Sep 20, 2023
| } else { | ||
| if (conf.getInt(PropertyKey.UNDERFS_GCS_VERSION) == GCS_VERSION_TWO) { | ||
| try { | ||
| return GCSV2UnderFileSystem.createInstance(new AlluxioURI(path), conf); |
There was a problem hiding this comment.
why checkgcscredentials doesnt apply to this anymore?
There was a problem hiding this comment.
GCS v2 only need to provide json file, only v1 is using access key. #17985 make the wrong check so I just revert it
There was a problem hiding this comment.
then why it was merged in the first place? sorry I don't have the context and I don't want to make the call of LGTM, if some bugs are introduced as part of other PR, can u plz let the related group know?
There was a problem hiding this comment.
I think this change is OK for GCS v2.
|
Tested locally and it works |
|
alluxio-bot, merge this please |
|
@zhezhidashi fixed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix GCSV2UnderFileSystem initialization
Why are the changes needed?
not able to create ufs instance if not set access key, which should not be a requirement for gcs v2
Does this PR introduce any user facing changes?
na