Bring back integration tests #18313

YichuanSun · 2023-10-23T06:10:22Z

What changes are proposed in this pull request?

All integration tests do not run now, this PR fixs it.

Why are the changes needed?

Fix bug.

Does this PR introduce any user facing changes?

No.

YichuanSun · 2023-10-23T06:51:21Z

.github/workflows/java8_integration_tests.yml

@@ -58,7 +58,6 @@ jobs:
          mkdir -p ~/.m2
          ALLUXIO_DOCKER_NO_TTY=true \
          ALLUXIO_DOCKER_GIT_CLEAN=true \
-          ALLUXIO_DOCKER_MVN_PROJECT_LIST=dora/tests \


This is just a quick fix, the entire fix should be discussed further.

PTAL👻! @Xenorith

Because all integration tests are not run about three months, now so many fails appears in the workflows below.

i think this is the correct fix for this file. but i think it also needs to be applied for the file at .github/workflows/java8_integration_tests_ft.yml and .github/workflows/java8_integration_tests_webui.yml

applied

i think this is the correct fix for this file. but i think it also needs to be applied for the file at .github/workflows/java8_integration_tests_ft.yml and .github/workflows/java8_integration_tests_webui.yml

…yml and java8_integration_tests_webui.yml.

dora/tests/integration/src/test/java/alluxio/client/fs/io/FileInStreamIntegrationTest.java

dora/tests/integration/src/test/java/alluxio/client/hadoop/FileSystemAclIntegrationTest.java

.github/workflows/java8_integration_tests_webui.yml

Xenorith · 2023-10-24T13:09:35Z

since all the integration test builds run under 25min which is the duration of the checkstyle build, there doesn't need to be any rebalancing of tests

jiacheliu3 · 2023-10-25T05:48:08Z

2023-10-25T02:23:18.7357259Z 02:23:18.733 [ERROR] Tests run: 4, Failures: 0, Errors: 2, Skipped: 1, Time elapsed: 11.942 s <<< FAILURE! - in alluxio.web.WebServerIntegrationTest
2023-10-25T02:23:18.7358885Z 02:23:18.734 [ERROR] alluxio.web.WebServerIntegrationTest.metricsJson  Time elapsed: 9.489 s  <<< ERROR!
2023-10-25T02:23:18.7359796Z java.lang.NullPointerException
2023-10-25T02:23:18.7360479Z 	at alluxio.client.rest.TestCase.getResponse(TestCase.java:119)
2023-10-25T02:23:18.7361622Z 	at alluxio.client.rest.TestCase.runAndGetResponse(TestCase.java:255)
2023-10-25T02:23:18.7362697Z 	at alluxio.web.WebServerIntegrationTest.verifyMetricsJson(WebServerIntegrationTest.java:74)
2023-10-25T02:23:18.7363890Z 	at alluxio.web.WebServerIntegrationTest.metricsJson(WebServerIntegrationTest.java:64)
2023-10-25T02:23:18.7364863Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-10-25T02:23:18.7365807Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2023-10-25T02:23:18.7366906Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-10-25T02:23:18.7367814Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2023-10-25T02:23:18.7368699Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2023-10-25T02:23:18.7369827Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2023-10-25T02:23:18.7370978Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-10-25T02:23:18.7372106Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2023-10-25T02:23:18.7373290Z 	at alluxio.testutils.LocalAlluxioClusterResource$1.evaluate(LocalAlluxioClusterResource.java:198)
2023-10-25T02:23:18.7374561Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
2023-10-25T02:23:18.7375846Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
2023-10-25T02:23:18.7376848Z 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2023-10-25T02:23:18.7377492Z 	at java.lang.Thread.run(Thread.java:750)
2023-10-25T02:23:18.7377832Z 
2023-10-25T02:23:18.7378481Z 02:23:18.734 [ERROR] alluxio.web.WebServerIntegrationTest.metricsJson  Time elapsed: 0.866 s  <<< ERROR!
2023-10-25T02:23:18.7379371Z java.lang.NullPointerException
2023-10-25T02:23:18.7379997Z 	at alluxio.client.rest.TestCase.getResponse(TestCase.java:119)
2023-10-25T02:23:18.7380851Z 	at alluxio.client.rest.TestCase.runAndGetResponse(TestCase.java:255)
2023-10-25T02:23:18.7381914Z 	at alluxio.web.WebServerIntegrationTest.verifyMetricsJson(WebServerIntegrationTest.java:74)
2023-10-25T02:23:18.7383069Z 	at alluxio.web.WebServerIntegrationTest.metricsJson(WebServerIntegrationTest.java:64)
2023-10-25T02:23:18.7384028Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-10-25T02:23:18.7384957Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2023-10-25T02:23:18.7386054Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-10-25T02:23:18.7386957Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2023-10-25T02:23:18.7387836Z 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
2023-10-25T02:23:18.7388941Z 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2023-10-25T02:23:18.7390238Z 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
2023-10-25T02:23:18.7391377Z 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2023-10-25T02:23:18.7392676Z 	at alluxio.testutils.LocalAlluxioClusterResource$1.evaluate(LocalAlluxioClusterResource.java:198)
2023-10-25T02:23:18.7393957Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
2023-10-25T02:23:18.7395253Z 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
2023-10-25T02:23:18.7396247Z 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2023-10-25T02:23:18.7396893Z 	at java.lang.Thread.run(Thread.java:750)
2023-10-25T02:23:18.7397233Z 
2023-10-25T02:23:19.1130925Z 02:23:19.112 [INFO] 
2023-10-25T02:23:19.1131620Z 02:23:19.112 [INFO] Results:
2023-10-25T02:23:19.1132652Z 02:23:19.112 [INFO] 
2023-10-25T02:23:19.1133202Z 02:23:19.112 [ERROR] Errors: 
2023-10-25T02:23:19.1138324Z 02:23:19.112 [ERROR] alluxio.web.WebServerIntegrationTest.metricsJson
2023-10-25T02:23:19.1143606Z 02:23:19.112 [ERROR]   Run 1: WebServerIntegrationTest.metricsJson:64->verifyMetricsJson:74 » NullPointer
2023-10-25T02:23:19.1145262Z 02:23:19.112 [ERROR]   Run 2: WebServerIntegrationTest.metricsJson:64->verifyMetricsJson:74 » NullPointer

jiacheliu3 · 2023-10-25T09:49:46Z

alluxio-bot, merge this please

a previous PR #18313 restored the integration tests but caused the unit tests to also run with the integration tests. the issue was correctly identified as an issue with the maven project list but the underlying problem was that the project name was not correctly set; `dora/tests` is not a module. it was previously a module until `dora/tests/testcontainers` was introduced, thus separating testcontainer tests vs integration tests. this fix updates the previous project list with the correct module name pr-link: #18392 change-id: cid-5f899f224abfbea4b7608d72cc2d38fed6449836

All integration tests do not run now, this PR fixs it. Fix bug. No. pr-link: Alluxio#18313 change-id: cid-e3f71f5b817624c45b8a3fc2baae2b08b99cd109

### What changes are proposed in this pull request? All integration tests do not run now, this PR fixs it. ### Why are the changes needed? Fix bug. ### Does this PR introduce any user facing changes? No. pr-link: Alluxio#18313 change-id: cid-e3f71f5b817624c45b8a3fc2baae2b08b99cd109

a previous PR Alluxio#18313 restored the integration tests but caused the unit tests to also run with the integration tests. the issue was correctly identified as an issue with the maven project list but the underlying problem was that the project name was not correctly set; `dora/tests` is not a module. it was previously a module until `dora/tests/testcontainers` was introduced, thus separating testcontainer tests vs integration tests. this fix updates the previous project list with the correct module name pr-link: Alluxio#18392 change-id: cid-5f899f224abfbea4b7608d72cc2d38fed6449836

YichuanSun added 2 commits October 23, 2023 14:07

just for a test.

bbcdcae

delete the line in problem.

ce25478

YichuanSun commented Oct 23, 2023

View reviewed changes

YichuanSun requested a review from Xenorith October 23, 2023 06:51

YichuanSun added 4 commits October 23, 2023 15:44

Merge branch 'main' into BringBackIntegrationTest

d71fc60

Resolve build failure.

e01f73e

Merge branch 'main' into BringBackIntegrationTest

f8ccf51

ignore the broken tests.

f3c8ed0

YichuanSun added the type-bug This issue is about a bug label Oct 23, 2023

YichuanSun self-assigned this Oct 23, 2023

YichuanSun added 3 commits October 23, 2023 18:16

append more ignores.

1b7070a

delete ALLUXIO_DOCKER_MVN_PROJECT_LIST in java8_integration_tests_ft.…

4b22085

…yml and java8_integration_tests_webui.yml.

Merge branch 'main' into BringBackIntegrationTest

a4dc837

Xenorith requested changes Oct 24, 2023

View reviewed changes

handles comments.

5149211

Xenorith approved these changes Oct 25, 2023

View reviewed changes

ignore failed WebServerIntegrationTest

184549b

jiacheliu3 changed the title ~~Bring Back integration tests~~ Bring back integration tests Oct 25, 2023

alluxio-bot merged commit e830663 into Alluxio:main Oct 25, 2023
14 checks passed

This was referenced Nov 7, 2023

Remove duplicated tests in workflows #18379

Closed

Fix integration tests again #18392

Merged

YichuanSun added a commit to YichuanSun/alluxio that referenced this pull request Nov 17, 2023

Bring back integration tests

550aacf

All integration tests do not run now, this PR fixs it. Fix bug. No. pr-link: Alluxio#18313 change-id: cid-e3f71f5b817624c45b8a3fc2baae2b08b99cd109

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring back integration tests #18313

Bring back integration tests #18313

YichuanSun commented Oct 23, 2023 •

edited

Loading

YichuanSun Oct 23, 2023

YichuanSun Oct 23, 2023

YichuanSun Oct 23, 2023

Xenorith Oct 23, 2023

YichuanSun Oct 23, 2023

Xenorith commented Oct 24, 2023

jiacheliu3 commented Oct 25, 2023

jiacheliu3 commented Oct 25, 2023

Bring back integration tests #18313

Bring back integration tests #18313

Conversation

YichuanSun commented Oct 23, 2023 • edited Loading

What changes are proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user facing changes?

YichuanSun Oct 23, 2023

Choose a reason for hiding this comment

YichuanSun Oct 23, 2023

Choose a reason for hiding this comment

YichuanSun Oct 23, 2023

Choose a reason for hiding this comment

Xenorith Oct 23, 2023

Choose a reason for hiding this comment

YichuanSun Oct 23, 2023

Choose a reason for hiding this comment

Xenorith commented Oct 24, 2023

jiacheliu3 commented Oct 25, 2023

jiacheliu3 commented Oct 25, 2023

YichuanSun commented Oct 23, 2023 •

edited

Loading