Fix the time check logic for judging stale client channels to be inac… #18340
Conversation
|
Thank you for your pull request. |
|
Thanks for your fix, would you mind sending us the CLA like alluxio-bot said? @xiaohu-liu |
|
The default value actually meets our needs. What is the default value of 3 days based on? @YichuanSun |
I don't know either, it is just like a magic number. |
is there any tool to generate an electronic signature ? what type of tool you advice to use? |
|
I think it can be merged if you have sent the CLA. Thanks for your work! @xiaohu-liu |
|
Aha, the first time I wrote my name with an ink pen, took a picture, then used a scanning app to generate a black-white pdf file, then cut my electronic signature and pasted it on the CLA pdf. |
|
alluxio-bot, merge this please |
### What changes are proposed in this pull request? Fix bug involved by Alluxio#18332. Alter the time judgment logic for judging whether stale client channels are inactive. Using the LocaTime object cannot correctly judge whether a channel client is inactive, because a LocalTime plus or minus time offset only changes the hour, minute, second attribute value, and It will not affect the date, you actually need to use the LocalDateTime object instead. ### Why are the changes needed? Please clarify why the changes are needed. For instance, In the code, the LocaTime class is used to determine that a client channel is inactive. The LocalTime object adds or subtracts the time offset. It only changes the hour, minute and second attribute value and does not affect the date. In fact, you need to use the LocalDateTime object. In other words, the three-day certification cycle judgment should be based on date and time, not just time. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including None pr-link: Alluxio#18340 change-id: cid-5b69e0c87d3bad8556ae27d491f3e0dc567378b9
What changes are proposed in this pull request?
Fix bug involved by #18332.
Alter the time judgment logic for judging whether stale client channels are inactive. Using the LocaTime object cannot correctly judge whether a channel client is inactive, because a LocalTime plus or minus time offset only changes the hour, minute, second attribute value, and It will not affect the date, you actually need to use the LocalDateTime object instead.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
In the code, the LocaTime class is used to determine that a client channel is inactive. The LocalTime object adds or subtracts the time offset. It only changes the hour, minute and second attribute value and does not affect the date. In fact, you need to use the LocalDateTime object. In other words, the three-day certification cycle judgment should be based on date and time, not just time.
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including
None