Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file mtime display when ufs mtime is not null #18358

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

lfyzjck
Copy link
Contributor

@lfyzjck lfyzjck commented Nov 2, 2023

What changes are proposed in this pull request?

#18357

Why are the changes needed?

mtime display error when ufs is hdfs
企业微信截图_9ff2cbaf-4e24-4cbc-ae11-6a5ace7812f1

after this commit:

企业微信截图_8c7ee012-851c-425e-a4c1-d22f0d39984b

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs. no
  2. addition or removal of property keys. no
  3. webui. no

@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to cla@alluxio.org

@humengyu2012
Copy link
Contributor

@elega Do you know who to look for this?

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word must be capitalized
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@elega elega changed the title fix file mtime display when ufs mtime is not null Fix file mtime display when ufs mtime is not null Nov 2, 2023
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

@elega
Copy link
Contributor

elega commented Nov 3, 2023

Thanks for the great work.. Can merge this once the CICD tests pass

Copy link
Contributor

@humengyu2012 humengyu2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HelloHorizon
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@HelloHorizon HelloHorizon added area-ufs Under File Storage type-bug This issue is about a bug labels Nov 3, 2023
@HelloHorizon
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 24ff6b5 into Alluxio:main Nov 3, 2023
14 checks passed
ssz1997 pushed a commit to ssz1997/alluxio that referenced this pull request Dec 15, 2023
### What changes are proposed in this pull request?

Alluxio#18357

### Why are the changes needed?

mtime display error when ufs is hdfs
![企业微信截图_9ff2cbaf-4e24-4cbc-ae11-6a5ace7812f1](https://github.com/Alluxio/alluxio/assets/800042/606cbcb0-b07f-4f91-8919-b1fe1b9e6dcc)

after this commit:

![企业微信截图_8c7ee012-851c-425e-a4c1-d22f0d39984b](https://github.com/Alluxio/alluxio/assets/800042/e05bfed5-c929-43c1-a633-6b6dee3f10ef)



### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs. no
  2. addition or removal of property keys. no
  3. webui. no

			pr-link: Alluxio#18358
			change-id: cid-54cc12a64383e77e5cd52b7ac89976714a93612b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ufs Under File Storage type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants