Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMALLFIX] Remove unused objects initialize #18380

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

lfyzjck
Copy link
Contributor

@lfyzjck lfyzjck commented Nov 6, 2023

What changes are proposed in this pull request?

Why are the changes needed?

objects is initialized by empty array but we never used this default value.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs. no
  2. addition or removal of property keys. no
  3. webui. no

@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to cla@alluxio.org

@lfyzjck lfyzjck changed the title [SMARTFIX] Remove unused objects initialize [SMALLFIX] Remove unused objects initialize Nov 6, 2023
Copy link
Contributor

@elega elega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elega elega added the type-code-quality code quality improvement label Nov 7, 2023
Copy link
Contributor

@Jackson-Wang-7 Jackson-Wang-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HelloHorizon
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit bd99175 into Alluxio:main Nov 7, 2023
14 checks passed
ssz1997 pushed a commit to ssz1997/alluxio that referenced this pull request Dec 15, 2023
### What changes are proposed in this pull request?



### Why are the changes needed?

`objects` is initialized by empty array but we never used this default value.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs. no
  2. addition or removal of property keys. no
  3. webui. no

			pr-link: Alluxio#18380
			change-id: cid-f16cc464ebc647d4c9be79b2151fb06c4ec71ed4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-code-quality code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants